hw/audio/intel-hda: Fix MSI capability address
PATCH 1/1 hw/audio/intel-hda: Fix MSI capability address
From: Jan Kiszka <[email protected]>
According to ICH9 spec, the MSI capability is located at 0x60. This is important for guest drivers that do not parse the capability chain and use absolute addresses instead.
--- hw/audio/intel-hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/audio/intel-hda.c +1 -1
@@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci) "intel-hda", 0x4000);pci_register_bar (&d->pci,0 ,0 , &d->mmio);if (d->msi) { -msi_init (&d->pci,0x50 ,1 , true, false); +msi_init (&d->pci,0x60 ,1 , true, false); } hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
Signature · 1 line
1.8.1.1.298.ge7eed54
Il 27/07/2014 08:57, Jan Kiszka ha scritto:
Quoted 17 lines
From: Jan Kiszka <[email protected]>
According to ICH9 spec, the MSI capability is located at
0x60. This is important for guest drivers that do not parse the capability chain and use absolute addresses instead.Signed-off-by Jan Kiszka <[email protected]>--- hw/audio/intel-hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/audio/intel-hda.c +0
-0
hw/audio/intel-hda.c static int intel_hda_init(PCIDevice *pci) · line 1147
Quoted 8 lines
hw/audio/intel-hda.c +1
-1@@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci) "intel-hda", 0x4000);pci_register_bar (&d->pci,0 ,0 , &d->mmio);if (d->msi) { -msi_init (&d->pci,0x50 ,1 , true, false); +msi_init (&d->pci,0x60 ,1 , true, false); } hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
Does this need a compat property?
Paolo
Quoted 24 lines · Paolo Bonzini
Il 27/07/2014 08:57, Jan Kiszka ha scritto:
Quoted 23 lines
From: Jan Kiszka <[email protected]>
According to ICH9 spec, the MSI capability is located at
0x60. This is important for guest drivers that do not parse the capability chain and use absolute addresses instead.Signed-off-by Jan Kiszka <[email protected]>--- hw/audio/intel-hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/audio/intel-hda.c +1
-1@@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci) "intel-hda", 0x4000);pci_register_bar (&d->pci,0 ,0 , &d->mmio);if (d->msi) { -msi_init (&d->pci,0x50 ,1 , true, false); +msi_init (&d->pci,0x60 ,1 , true, false); }
Quoted 4 lines
hw/audio/intel-hda.c static int intel_hda_init(PCIDevice *pci) · line 1147
Quoted 2 lines
hw/audio/intel-hda.c +0
-0hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),Does this need a compat property?
Sigh, right, it's guest visible.
Jan