Skip to contentSkip to conversation

cpuset: fix the WARN_ON() in update_nodemasks_hier()

PATCH Applied Li Zefan 2 participants 2 messages Jul 30, 2014 cgroup

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 cpuset: fix the WARN_ON() in update_nodemasks_hier()

The WARN_ON() is used to check if we break the legal hierarchy, on which the effective mems should be equal to configured mems.

Reported-by Mike Qiu <[email protected]>
Tested-by Mike Qiu <[email protected]>
Signed-off-by Li Zefan <[email protected]>
---
 kernel/cpuset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cpuset.c +1 -1
index 53a9bbf..baa155c 100644
@@ -1136,7 +1136,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
 		mutex_unlock(&callback_mutex);
 
 		WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
-			nodes_equal(cp->mems_allowed, cp->effective_mems));
+			!nodes_equal(cp->mems_allowed, cp->effective_mems));
 
 		update_tasks_nodemask(cp);
Signature · 1 line
1.8.0.2