Skip to contentSkip to conversation

usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

REVERT Joseph Salisbury 2 participants 5 messages Jul 30, 2014 – Aug 13, 2014 Stable branch

lore
Share & tools
lore
#0 lore raw

Hello,

A bug report was opened against Ubuntu[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 1f81b6d22a5980955b01e08cf27fb745dc9b686f

Author: Julius Werner <[email protected]>
Date:   Fri Apr 25 19:20:13 2014 +0300

usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

Please consider reverting commit SHA1 in the next mainline release as well as the affected stable releases. It was included upstream as of v3.15-rc3.

An upstream bug report can be found at:
https://bugzilla.kernel.org/show_bug.cgi?id=75521

Julius, I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to continue with this revert request?

Sincerely,

Joseph Salisbury

[0] http://pad.lv/1350480

#1 lore raw

Hi Joseph,

Quoted 3 lines

Julius, I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to continue with this revert request?

As I understand it, this crash will disappear with Mathias' new rework for finding the cycle state bit in
http://www.spinics.net/lists/linux-usb/msg111259.html , so a revert should not be necessary.

#2 lore raw
Quoted 9 lines · Julius Werner

Hi Joseph,

Quoted 3 lines

Julius, I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to continue with this revert request?

As I understand it, this crash will disappear with Mathias' new rework for finding the cycle state bit in
http://www.spinics.net/lists/linux-usb/msg111259.html , so a revert should not be necessary.

Thanks, Julius. We will test that patch and report back.

Thanks,

Joe

#3 lore raw
In reply to Julius Werner
Quoted 9 lines · Julius Werner

Hi Joseph,

Quoted 3 lines

Julius, I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to continue with this revert request?

As I understand it, this crash will disappear with Mathias' new rework for finding the cycle state bit in
http://www.spinics.net/lists/linux-usb/msg111259.html , so a revert should not be necessary.

Hi Julius / Mathias,

I was able to built a test kernel with the patch against 3.16-rc7. However, the patch would not compile against the 3.13.y stable tree(I'll debug why further). Is there plans for a version of the patch that will work with stable kernels?

Thanks,

Joe

#4 lore raw
Quoted 12 lines · Joseph Salisbury
Quoted 9 lines · Julius Werner

Hi Joseph,

Quoted 3 lines

Julius, I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to continue with this revert request?

As I understand it, this crash will disappear with Mathias' new rework for finding the cycle state bit in
http://www.spinics.net/lists/linux-usb/msg111259.html , so a revert should not be necessary.

Hi Julius / Mathias,

Quoted 11 lines

I was able to built a test kernel with the patch against 3.16-rc7. However, the patch would not compile against the 3.13.y stable tree(I'll debug why further). Is there plans for a version of the patch that will work with stable kernels?

Thanks,

Joe

Just curious if there is an update on a version of the patch that will build against the stable kernels? If not, I can dig deeper to find the build failure.

Thanks,

Joe