r8152: add missing Makefile rule

From: JF Le Fillatre <[email protected]>

Add missing Makefile rule for r8152 driver

In the current kernel the r8152 driver is *never* built because of a missing rule in drivers/net/Makefile, despite being selected as built-in or module in the .config file. There is no error message or warning to indicate that the driver isn't built. This change adds the rule and lets the driver build.

Tested as built-in and module for 3.15.8.

Signed-off by: JF Le Fillatre <[email protected]>

---

Is seems that this issue has existed ever since the driver was added back in 3.10. In Linus' git tree the drivers/net/Makefile was last modified before the inclusion of the driver, so I don't know if it's ever been possible to build it.

@@ -65,6 +65,7 @@ obj-$(CONFIG_USB_CATC)          += usb/
 obj-$(CONFIG_USB_KAWETH)        += usb/
 obj-$(CONFIG_USB_PEGASUS)       += usb/
 obj-$(CONFIG_USB_RTL8150)       += usb/
+obj-$(CONFIG_USB_RTL8152)       += usb/
 obj-$(CONFIG_USB_HSO)        += usb/
 obj-$(CONFIG_USB_USBNET)        += usb/
 obj-$(CONFIG_USB_ZD1201)        += usb/

From: [email protected]
Date: Sat, 02 Aug 2014 01:26:40 +0200

It gets built, as long as at least one other USB networking driver has been selected.

Most people (distributions, developers, maintainers) select all drivers or some large subset thereof, so would never actually run into this problem.

You'd have to specifically have a configuration that enabled r8152 and no other USB networking driver, in order to trigger this.

Anyways, I'll apply this, thanks.

Very true, thank you for pointing it out. If you haven't done so yet, the patch description could be changed to something like:

When it is the only USB net driver selected, the r8152 driver doesn't get built because of a missing rule in drivers/net/Makefile. This change adds the rule and lets the driver build.

Thank you!
JF