arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

PATCH Applied Chen Gang 2 participants 7 messages Aug 6, 2014 – Sep 1, 2014 Microblaze architecture

Share & tools

Chen Gang

author

2014-08-06 13:33 UTC #0 lore raw

PATCH 1/1 arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

"entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it. So need include "linux/linkage.h" to use generic one instead of.

The related error (with allmodconfig under microblaze):

CC [M] drivers/net/ethernet/emulex/benet/be_main.o
In file included from ./arch/microblaze/include/asm/processor.h:17:0,
from include/linux/prefetch.h:14,
from drivers/net/ethernet/emulex/benet/be_main.c:18:
./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'

   extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
                     ^

Signed-off-by Chen Gang <[email protected]>

---
 arch/microblaze/include/asm/entry.h | 1 +
 1 file changed, 1 insertion(+)

arch/microblaze/include/asm/entry.h +1 -0

index b4a4cb1..596e485 100644
@@ -15,6 +15,7 @@
 
 #include <asm/percpu.h>
 #include <asm/ptrace.h>
+#include <linux/linkage.h>
 
 /*
  * These are per-cpu variables required in entry.S, among other

Signature · 1 line

1.7.11.7

Chen Gang

author

2014-08-19 15:47 UTC #1 lore raw

Hello maintainers:

Please help check the related 2 patches when you have time.

Thanks.

Quoted 31 lines · Chen Gang

"entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it. So need include "linux/linkage.h" to use generic one instead of.
The related error (with allmodconfig under microblaze):
CC [M] drivers/net/ethernet/emulex/benet/be_main.o
In file included from ./arch/microblaze/include/asm/processor.h:17:0,
from include/linux/prefetch.h:14,
from drivers/net/ethernet/emulex/benet/be_main.c:18:
./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
   extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
                     ^
Signed-off-by Chen Gang <[email protected]>
---
 arch/microblaze/include/asm/entry.h | 1 +
 1 file changed, 1 insertion(+)
arch/microblaze/include/asm/entry.h +1 -0
index b4a4cb1..596e485 100644
@@ -15,6 +15,7 @@
 
 #include <asm/percpu.h>
 #include <asm/ptrace.h>
+#include <linux/linkage.h>
 
 /*
  * These are per-cpu variables required in entry.S, among other

Signature · 3 lines

Chen Gang

Open share and attitude like air water and life which God blessed

Chen Gang

author

2014-08-24 08:01 UTC #2 lore raw

Hello All:

Is microblaze for Linux upstream kernel still alive?

Before I get confirmation, I should do nothing for microblaze to avoid sending spams to kernel mailing list.

Thanks.

Quoted 40 lines · Chen Gang

Hello maintainers:
Please help check the related 2 patches when you have time.
Thanks.
Quoted 31 lines · Chen Gang
"entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it. So need include "linux/linkage.h" to use generic one instead of.
The related error (with allmodconfig under microblaze):
CC [M] drivers/net/ethernet/emulex/benet/be_main.o
In file included from ./arch/microblaze/include/asm/processor.h:17:0,
from include/linux/prefetch.h:14,
from drivers/net/ethernet/emulex/benet/be_main.c:18:
./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
   extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
                     ^
Signed-off-by Chen Gang <[email protected]>
---
 arch/microblaze/include/asm/entry.h | 1 +
 1 file changed, 1 insertion(+)
arch/microblaze/include/asm/entry.h +1 -0
index b4a4cb1..596e485 100644
@@ -15,6 +15,7 @@
 
 #include <asm/percpu.h>
 #include <asm/ptrace.h>
+#include <linux/linkage.h>
 
 /*
  * These are per-cpu variables required in entry.S, among other

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Michal Simek

maintainer

2014-09-01 13:40 UTC #3 lore raw

Hi Chen,

Quoted 6 lines · Chen Gang

Hello All:
Is microblaze for Linux upstream kernel still alive?
Before I get confirmation, I should do nothing for microblaze to avoid sending spams to kernel mailing list.

Yes. Microblaze is alive. I am just busy over summer in Europe.

I will reply the patch you sent.

Thanks,
Michal

Signature · 5 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Michal Simek

maintainer Applied

2014-09-01 13:59 UTC #6 lore raw

In reply to Chen Gang

Quoted 24 lines · Chen Gang

"entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it. So need include "linux/linkage.h" to use generic one instead of.
The related error (with allmodconfig under microblaze):
CC [M] drivers/net/ethernet/emulex/benet/be_main.o
In file included from ./arch/microblaze/include/asm/processor.h:17:0,
from include/linux/prefetch.h:14,
from drivers/net/ethernet/emulex/benet/be_main.c:18:
./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
   extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
                     ^
Signed-off-by Chen Gang <[email protected]>
---
 arch/microblaze/include/asm/entry.h | 1 +
 1 file changed, 1 insertion(+)
arch/microblaze/include/asm/entry.h +0 -0
index b4a4cb1..596e485 100644

arch/microblaze/include/asm/entry.h line 21

Quoted 7 lines

arch/microblaze/include/asm/entry.h +1 -0

@@ -15,6 +15,7 @@
 
 #include <asm/percpu.h>
 #include <asm/ptrace.h>
+#include <linux/linkage.h>
 
 /*
  * These are per-cpu variables required in entry.S, among other

Applied.

Thanks,
Michal

Signature · 5 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Michal Simek

maintainer

2014-09-01 14:01 UTC #5 lore raw

In reply to Chen Gang

Quoted 3 lines · Chen Gang

Hello maintainers:
Please help check the related 2 patches when you have time.

Can you resend that second one?
I have just this one.
arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

Thanks,
Michal

Signature · 5 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Chen Gang

author

2014-09-01 15:30 UTC #4 lore raw

In reply to Michal Simek

Quoted 5 lines · Michal Simek

Hi Chen,
Quoted 2 lines · Chen Gang
Hello All:

Quoted 9 lines

Quoted 4 lines
Is microblaze for Linux upstream kernel still alive?
Before I get confirmation, I should do nothing for microblaze to avoid sending spams to kernel mailing list.
Yes. Microblaze is alive. I am just busy over summer in Europe.
I will reply the patch you sent.

OK, thanks. And I shall continue to try to let microblaze pass allmodconfig (hope I can finish within this month).

And I forward the other patch in an individual thread, please help check when you have time.

Thanks.

Signature · 3 lines

Chen Gang

Open share and attitude like air water and life which God blessed