apic: Fix reported DFR content

PATCH Applied Jan Kiszka 2 participants 3 messages Aug 9, 2014 – Aug 13, 2014

lore

Share & tools

lore

Jan Kiszka

author

2014-08-09 14:06 UTC #0 lore raw

PATCH 1/1 apic: Fix reported DFR content

From: Jan Kiszka <[email protected]>

IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.

Fixes Jailhouse hypervisor start with in-kernel irqchips off.

Signed-off-by Jan Kiszka <[email protected]>

---
 hw/intc/apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

hw/intc/apic.c +1 -1

index ef19e55..03ff9e9 100644
@@ -698,7 +698,7 @@ static uint32_t apic_mem_readl(void *opaque, hwaddr addr)
         val = s->log_dest << 24;
         break;
     case 0x0e:
-        val = s->dest_mode << 28;
+        val = (s->dest_mode << 28) | 0xfffffff;
         break;
     case 0x0f:
         val = s->spurious_vec;

Signature · 1 line

1.8.1.1.298.ge7eed54

Michael Tokarev

Applied

2014-08-13 06:14 UTC #1 lore raw

Quoted 5 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>
IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
Fixes Jailhouse hypervisor start with in-kernel irqchips off.

Applied to -trivial, thank you!

Are the other similar cases in there okay? Say, 0x0d or 0x02 which also uses shifts like this one?

/mjt

Jan Kiszka

author

2014-08-13 07:09 UTC #2 lore raw

Quoted 11 lines · Michael Tokarev

Quoted 5 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
Fixes Jailhouse hypervisor start with in-kernel irqchips off.
Applied to -trivial, thank you!
Are the other similar cases in there okay? Say, 0x0d or 0x02 which also uses shifts like this one?

Nope, didn't find any.

Jan