Skip to contentSkip to conversation

ath6kl DT support and multiple instances.

DISCUSSION Srinivas Kandagatla 2 participants 2 messages Aug 19, 2014

lore
Share & tools
lore
#0 lore raw

Hi Kalle,

I noticed that ath6kl partially supports Device trees, via check_device_tree() function in init.c.

I have a use case for adding reset line and pinctrl properties to this dt bindings, but soon realized that this function would not work for multiple instances of the driver, as there is no direct association/binding of dt node and driver instance.

Just wondering if this is a know limitation and there will be no possible multiple instances of this driver?

is check_device_tree function obsolete?

should I care about multiple instances?

Other than adding static code in the board file, are there any other options to pass platform data like reset gpio lines and pinctrl properties to the driver?

thanks,
srini

#1 lore raw

Hi Srinivas,

Quoted 2 lines · Srinivas Kandagatla

I noticed that ath6kl partially supports Device trees, via check_device_tree() function in init.c.

That's really old code. Sam Leffler wrote that back in 2011 and IIRC nobody has touched it since.

Quoted 9 lines

I have a use case for adding reset line and pinctrl properties to this dt bindings, but soon realized that this function would not work for multiple instances of the driver, as there is no direct association/binding of dt node and driver instance.

Just wondering if this is a know limitation and there will be no possible multiple instances of this driver?

is check_device_tree function obsolete?

I'm not familiar with the device tree at all so I can't really comment much, except that I'm happy to take patches :)

Quoted 1 line

should I care about multiple instances?

Yes, I think you should.

Quoted 3 lines

Other than adding static code in the board file, are there any other options to pass platform data like reset gpio lines and pinctrl properties to the driver?

Few years back we talked about adding function pointers to the board files for that, but there never were any patches.

Signature · 1 line
Kalle Valo