Skip to contentSkip to conversation

KVM: x86: handle idiv overflow at kvm_write_tsc for stable-3.10

DISCUSSION Philipp Hahn 1 participant 1 message Sep 9, 2014 2 messages not in the archive

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive

Hello Marcelo,

Quoted 24 lines · Marcelo Tosatti
Quoted 23 lines · Philipp Hahn

can we please 8915aa27d5efbb9185357175b0acf884325565f9 get applied to 3.10 too?

Quoted 7 lines

commit 8915aa27d5efbb9185357175b0acf884325565f9

Author: Marcelo Tosatti <[email protected]>
Date:   Tue Jun 11 23:31:12 2013 -0300

KVM: x86: handle idiv overflow at kvm_write_tsc

Its possible that idivl overflows (due to large delta stored in

usdiff,

Quoted 3 lines

valid scenario).

Create an exception handler to catch the overflow exception

(division by zero

Quoted 1 line
    is protected by vcpu->arch.virtual_tsc_khz check), and interpret

it accordingly

Quoted 6 lines

(delta is larger than USEC_PER_SEC).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=969644

...

Quoted 1 line
Quoted 1 line

...

Quoted 1 line

Yes, can you send the patch accordingly to the stable guidelines please?

Maybe I'm to stupid right now, but I find linux/Documentation/stable_kernel_rules.txt unclear on what I'm supposed to do:

1. cherry-pick the patch myself?
2. amend the commit message by adding the original commit it
3. where should the name of the stable branch go?
4. amend the commit message by adding myself as a tester? Or do I need to sign it off?
5. send that patch to <mailto:[email protected]>.

It did seem to have worked, as I never received an acknowledgement nor is it listed in
<http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git>.
Maybe you can do it and cc: me so I can do it right next time myself.

Thanks.

Philipp