Skip to contentSkip to conversation

drivers/target/target_core_transport.c: Fix typo issue to use 'buf' instead of 'len'

PATCH New Chen Gang 1 participant 1 message Sep 3, 2014

Subsystems (2)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/target/target_core_transport.c: Fix typo issue to use 'buf' instead of 'len'

It is a typo issue, need use 'buf' instead of 'len', the related warning with allmodconfig under microblaze:

drivers/target/target_core_transport.c: In function ‘transport_dump_vpd_ident_type’:
drivers/target/target_core_transport.c:956:9: warning: passing argument 1 of ‘strlen’ makes pointer from integer without a cast

   len = strlen(len);
         ^

In file included from include/linux/bitmap.h:8:0,
from include/linux/cpumask.h:11,
from include/linux/mm_types.h:12,
from include/linux/kmemcheck.h:4,
from include/linux/net.h:25,
from drivers/target/target_core_transport.c:26:
include/linux/string.h:83:24: note: expected ‘const char *’ but argument is of type ‘int’

 extern __kernel_size_t strlen(const char *);
                        ^
---
 drivers/target/target_core_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_transport.c +1 -1
index 1dd1181..3ce85ed 100644
@@ -953,7 +953,7 @@ int transport_dump_vpd_ident_type(
 		strlcat(buf, "SCSI name string\n", sizeof(buf));
 		break;
 	default:
-		len = strlen(len);
+		len = strlen(buf);
 		snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
 				vpd->device_identifier_type);
 		ret = -EINVAL;
Signature · 5 lines
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html