Compilation error on freshly pulled net-next?
Subsystems (2)
I was going to do some additional "floor sweeping" and put dev_consume_skb_any() into another driver or two, so I did a fresh pull of net-next and a make and got:
CC net/core/rtnetlink.onet/core/rtnetlink.c: In function ‘if_nlmsg_size’:net/core/rtnetlink.c:868:84: error: expected ‘;’ before ‘J’net/core/rtnetlink.c: At top level:net/core/rtnetlink.c:420:15: warning: ‘rtnl_link_get_size’ defined but not used [-Wunused-function] net/core/rtnetlink.c:497:15: warning: ‘rtnl_link_get_af_size’ defined but not used [-Wunused-function]
Looks like someone slipped a J in there and confused things:
+ rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS
+ IFLA_PORT_SELF */J + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
+ rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
(hopefully my mail client won't have mangled things too badly)
What is odd though is a git diff after I've replaced that 'J' with a return isn't giving me any output.
rick jones
David Miller
maintainerFrom: Rick Jones <[email protected]>
Date: Fri, 05 Sep 2014 14:47:43 -0700
Quoted 10 lines
Looks like someone slipped a J in there and confused things:
+
rtnl_port_size(dev, ext_filter_mask)/*IFLA_VF_PORTS+IFLA_PORT_SELF*/J +rtnl_link_get_size(dev)/*IFLA_LINKINFO*/
+rtnl_link_get_af_size(dev)/*IFLA_AF_SPEC*/(hopefully my mail client won't have mangled things too badly)
What is odd though is a git diff after I've replaced that 'J' with a return isn't giving me any output.
That doesn't exist in my tree.
Quoted 9 lines · David Miller
From: Rick Jones <[email protected]>
Date: Fri, 05 Sep 2014 14:47:43 -0700Quoted 6 lines
Looks like someone slipped a J in there and confused things:
+
rtnl_port_size(dev, ext_filter_mask)/*IFLA_VF_PORTS+IFLA_PORT_SELF*/J +rtnl_link_get_size(dev)/*IFLA_LINKINFO*/
+rtnl_link_get_af_size(dev)/*IFLA_AF_SPEC*/
Quoted 6 lines
Quoted 4 lines
(hopefully my mail client won't have mangled things too badly)
What is odd though is a git diff after I've replaced that 'J' with a return isn't giving me any output.
That doesn't exist in my tree.
That's good. Must have been some sort of glitch at my end, but what it could have been I've no clue. I guess I'll just chalk it up to gremlins and see about doing a little light floor sweeping then.
rick
Quoted 9 lines · David Miller
From: Rick Jones <[email protected]>
Date: Fri, 05 Sep 2014 14:47:43 -0700Quoted 6 lines
Looks like someone slipped a J in there and confused things:
+
rtnl_port_size(dev, ext_filter_mask)/*IFLA_VF_PORTS+IFLA_PORT_SELF*/J +rtnl_link_get_size(dev)/*IFLA_LINKINFO*/
+rtnl_link_get_af_size(dev)/*IFLA_AF_SPEC*/
Quoted 6 lines
Quoted 4 lines
(hopefully my mail client won't have mangled things too badly)
What is odd though is a git diff after I've replaced that 'J' with a return isn't giving me any output.
That doesn't exist in my tree.
Looks like data corruption to me. There is a one-bit difference between line-feed and J. Oh for more ECC-capable systems...
Signature · 1 line
Mark Rustad, Networking Division, Intel Corporation