Skip to contentSkip to conversation

arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break

PATCH In review Chen Gang 4 participants 10 messages Sep 14, 2014 – Sep 20, 2014 Microblaze architecture

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

---
 arch/microblaze/kernel/setup.c | 3 +++
 1 file changed, 3 insertions(+)
arch/microblaze/kernel/setup.c +3 -0
index ab5b488..8756d61 100644
@@ -18,6 +18,7 @@
 #include <linux/console.h>
 #include <linux/debugfs.h>
 #include <linux/of_fdt.h>
+#include <linux/screen_info.h>
 
 #include <asm/setup.h>
 #include <asm/sections.h>
@@ -42,6 +43,8 @@ DEFINE_PER_CPU(unsigned int, ENTRY_SP);	/* Saved SP on kernel entry */
 DEFINE_PER_CPU(unsigned int, R11_SAVE);	/* Temp variable for entry */
 DEFINE_PER_CPU(unsigned int, CURRENT_SAVE);	/* Saved current pointer */
 
+struct screen_info screen_info;
+
 unsigned int boot_cpuid;
 /*
  * Placed cmd_line to .data section because can be initialized from
Signature · 1 line
1.9.3
#1 lore raw

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Can microblaze actually have VGA?

If not, it's better to disable it.

BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS in drivers/video/console/Kconfig...

I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make VGA_CONSOLE depend on that, cfr.

commit f13399f033ae3d49e1808bacabd83d116844c94e
Merge: 049ffa8ab33a b2c32b32a212
Author: Linus Torvalds <[email protected]>
Date: Fri Nov 15 14:05:15 2013 -0800

Merge tag 'for-linus' of
git://linux-c6x.org/git/projects/linux-c6x-upstreaming

Pull Kconfig cleanups from Mark Salter:
"Remove some unused config options from C6X and clean up PC_PARPORT
dependencies. The latter was discussed here:

https://lkml.org/lkml/2013/10/8/12"

* tag 'for-linus' of git://linux-c6x.org/git/projects/linux-c6x-upstreaming:
c6x: remove unused COMMON_CLKDEV Kconfig parameter
Kconfig cleanup (PARPORT_PC dependencies)
x86: select ARCH_MIGHT_HAVE_PC_PARPORT
unicore32: select ARCH_MIGHT_HAVE_PC_PARPORT
sparc: select ARCH_MIGHT_HAVE_PC_PARPORT
sh: select ARCH_MIGHT_HAVE_PC_PARPORT
powerpc: select ARCH_MIGHT_HAVE_PC_PARPORT
parisc: select ARCH_MIGHT_HAVE_PC_PARPORT
mips: select ARCH_MIGHT_HAVE_PC_PARPORT
microblaze: select ARCH_MIGHT_HAVE_PC_PARPORT
m68k: select ARCH_MIGHT_HAVE_PC_PARPORT
ia64: select ARCH_MIGHT_HAVE_PC_PARPORT
arm: select ARCH_MIGHT_HAVE_PC_PARPORT
alpha: select ARCH_MIGHT_HAVE_PC_PARPORT
c6x: remove unused parameter in Kconfig

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#2 lore raw
Quoted 18 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Quoted 4 lines

Can microblaze actually have VGA?

If not, it's better to disable it.

Welcome the related microblaze maintainers ideas for it

Quoted 3 lines

BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS in drivers/video/console/Kconfig...

Welcome the related cris maintainers ideas for it.

Quoted 17 lines

I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make VGA_CONSOLE depend on that, cfr.

commit f13399f033ae3d49e1808bacabd83d116844c94e
Merge: 049ffa8ab33a b2c32b32a212
Author: Linus Torvalds <[email protected]>
Date: Fri Nov 15 14:05:15 2013 -0800

Merge tag 'for-linus' of
git://linux-c6x.org/git/projects/linux-c6x-upstreaming

Pull Kconfig cleanups from Mark Salter:
"Remove some unused config options from C6X and clean up PC_PARPORT
dependencies. The latter was discussed here:

https://lkml.org/lkml/2013/10/8/12"

Quoted 17 lines

* tag 'for-linus' of git://linux-c6x.org/git/projects/linux-c6x-upstreaming:
c6x: remove unused COMMON_CLKDEV Kconfig parameter
Kconfig cleanup (PARPORT_PC dependencies)
x86: select ARCH_MIGHT_HAVE_PC_PARPORT
unicore32: select ARCH_MIGHT_HAVE_PC_PARPORT
sparc: select ARCH_MIGHT_HAVE_PC_PARPORT
sh: select ARCH_MIGHT_HAVE_PC_PARPORT
powerpc: select ARCH_MIGHT_HAVE_PC_PARPORT
parisc: select ARCH_MIGHT_HAVE_PC_PARPORT
mips: select ARCH_MIGHT_HAVE_PC_PARPORT
microblaze: select ARCH_MIGHT_HAVE_PC_PARPORT
m68k: select ARCH_MIGHT_HAVE_PC_PARPORT
ia64: select ARCH_MIGHT_HAVE_PC_PARPORT
arm: select ARCH_MIGHT_HAVE_PC_PARPORT
alpha: select ARCH_MIGHT_HAVE_PC_PARPORT
c6x: remove unused parameter in Kconfig

At least for me, the contents above sounds reasonable.

And also thank you very much for always supporting me for sending 'global' patches for Kconfig.

But in honest, what I have done is not quite well, at present. And I should continue trying...

Thanks.

Signature · 3 lines
Chen Gang

Open share and attitude like air water and life which God blessed
#7 lore raw
In reply to Geert Uytterhoeven
Quoted 18 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Quoted 6 lines

Can microblaze actually have VGA?

If not, it's better to disable it.

BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS in drivers/video/console/Kconfig...

No CRIS platform has ever had a video console.

Quoted 2 lines

I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make VGA_CONSOLE depend on that, cfr.

Sounds reasonable, at least it can avoid the specific depends on !*arch* cruft.

Quoted 3 lines

Gr{oetje,eeting}s,

Geert

/^JN - Jesper Nilsson

Signature · 1 line
               Jesper Nilsson -- [email protected]
author
#8 lore raw
Quoted 26 lines · Jesper Nilsson
Quoted 18 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Quoted 6 lines

Can microblaze actually have VGA?

If not, it's better to disable it.

BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS in drivers/video/console/Kconfig...

Quoted 7 lines

No CRIS platform has ever had a video console.

Quoted 2 lines

I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make VGA_CONSOLE depend on that, cfr.

Sounds reasonable, at least it can avoid the specific depends on !*arch* cruft.

Thank you very much, next when I try the ARCH_MIGHT_HAVE_VGA, I shall process it (remove useless "screen_info").

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
maintainer
#3 lore raw
In reply to Chen Gang
Quoted 19 lines · Chen Gang
Quoted 18 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Quoted 6 lines
Quoted 4 lines

Can microblaze actually have VGA?

If not, it's better to disable it.

Welcome the related microblaze maintainers ideas for it

Is this is just about VGA or video console in general? There is xilinx FB driver and other FB are around too.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
#4 lore raw

Hi Michal,

Quoted 22 lines · Michal Simek
Quoted 21 lines · Chen Gang
Quoted 20 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Can microblaze actually have VGA?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

If not, it's better to disable it.

Welcome the related microblaze maintainers ideas for it

Is this is just about VGA or video console in general? There is xilinx FB driver and other FB are around too.

These days screen_info is only used by:
- vgacon,
- dummycon on ARM,
- a few fb drivers (efifb, intelfbdrv,sis, vesafb, and vga16fb).

E.g. m68k doesn't have it.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer
#5 lore raw
Quoted 33 lines · Geert Uytterhoeven

Hi Michal,

Quoted 22 lines · Michal Simek
Quoted 21 lines · Chen Gang
Quoted 20 lines · Geert Uytterhoeven

Hi Chen,

Quoted 14 lines · Chen Gang

Add default one just like other architectures have done (e.g. cris, score, sh ...), the related error with allmodconfig:

LD init/built-in.o
drivers/built-in.o: In function `vgacon_save_screen':
drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_resize':
drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to screen_info' drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to screen_info' drivers/built-in.o: In function `vgacon_switch':
drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to screen_info' drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to screen_info' follow
make: *** [vmlinux] Error 1

Can microblaze actually have VGA?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

If not, it's better to disable it.

Welcome the related microblaze maintainers ideas for it

Is this is just about VGA or video console in general? There is xilinx FB driver and other FB are around too.

Quoted 6 lines

These days screen_info is only used by:
- vgacon,
- dummycon on ARM,
- a few fb drivers (efifb, intelfbdrv,sis, vesafb, and vga16fb).

E.g. m68k doesn't have it.

ok. IRC I think I remember one non mainline FB driver which required it too. It breaks nothing for me that's why no problem to apply it.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
author
#6 lore raw

Thank all of your work. And I also try some patches for microblaze compiler, hope I can finish within this month (already got much help from related gcc maintainer). And next month, I shall start Qemu for microblaze.

Thanks again.

发自我的 iPad

Quoted 14 lines · 在 2014年9月16日,下午6:59,Michal Simek <[email protected]> 写道:
Quoted 11 lines
Quoted 4 lines
Quoted 1 line

Welcome the related microblaze maintainers ideas for it

Is this is just about VGA or video console in general? There is xilinx FB driver and other FB are around too.

These days screen_info is only used by:
- vgacon,
- dummycon on ARM,
- a few fb drivers (efifb, intelfbdrv,sis, vesafb, and vga16fb).

E.g. m68k doesn't have it.

ok. IRC I think I remember one non mainline FB driver which required it too. It breaks nothing for me that's why no problem to apply it.

author
#9 lore raw
In reply to Chen Gang
Quoted 2 lines · Chen Gang
Quoted 1 line · Jesper Nilsson

On Sun, Sep 14, 2014 at 10:45:23AM +0200, Geert Uytterhoeven wrote:

[...]

Quoted 7 lines
Quoted 3 lines

Sounds reasonable, at least it can avoid the specific depends on !*arch* cruft.

Thank you very much, next when I try the ARCH_MIGHT_HAVE_VGA, I shall process it (remove useless "screen_info").

Excuse me, after some trying, I guess, at present, I am not suitable to perform global architecture wide patches (e.g. ARCH_MIGHT_HAVE_VGA). So welcome any other members to help try.

I guess, in the future, after I finish all architectures allmodconfig, I shall be suitable for sending global architecture wide patches.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed