Skip to contentSkip to conversation

xfs/005: sync superblock modification to disk before mount test

PATCH New Eric Sandeen 1 participant 1 message Sep 16, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/005: sync superblock modification to disk before mount test

This test tries to directly corrupt the CRC field of the primary superblock by using xfs_io pwrite, but never syncs it to disk, so it's quite likely that the mount will not see the bad data.

---

tests/xfs/005 +1 -1
index 5d4534b..fade4bb 100755
@@ -61,7 +61,7 @@ rm -f $seqres.full
 _scratch_mkfs_xfs -m crc=1 >> $seqres.full 2>&1 || _fail "mkfs failed"
 
 # Zap the crc.  xfs_db updates the CRC post-write, so poke it directly
-$XFS_IO_PROG -c "pwrite 224 4" $SCRATCH_DEV | _filter_xfs_io
+$XFS_IO_PROG -c "pwrite 224 4" -c fsync $SCRATCH_DEV | _filter_xfs_io
 
 # should FAIL, the crc is bad; golden output contains mount failure
 _scratch_mount 2>&1 | filter_mount