Skip to contentSkip to conversation

FIX Me in pgtable.h

DISCUSSION nick 3 participants 5 messages Sep 23, 2014 – Sep 24, 2014

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed.
Thanks,
Nick

#1 lore raw
Quoted 4 lines · nick

Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed.

Dear Nick Krause,

Before you start coding - do you have necessary ARM-based hardware to test your changes?

Changing email won't remove LKML archives...

Best regards,
Krzysztof

author
#2 lore raw

I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed.
I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches.
It was never my goal to be a nuisance.
Nick

Quoted 20 lines · Krzysztof Koz?owski
Quoted 7 lines · nick

Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
and should be changed.

Dear Nick Krause,

Before you start coding - do you have necessary ARM-based hardware to test your changes?

Changing email won't remove LKML archives...

Best regards,
Krzysztof

#3 lore raw
In reply to nick
Quoted 7 lines · nick

Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed.
Thanks,
Nick

It's not clear to me how valuable fixing kern_addr_valid would actually be for arm. It seems to be used in exactly one place, fs/proc/kcore.c and the associated Kconfig is explicitly marked if !ARM. Nearly all other archs minus x86, arm64 and sparc are in the same boat as well.

Thanks,
Laura

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, hosted by The Linux Foundation
author
#4 lore raw
Quoted 9 lines · Laura Abbott
Quoted 7 lines · nick

Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed.
Thanks,
Nick

Quoted 8 lines

It's not clear to me how valuable fixing kern_addr_valid would actually be for arm. It seems to be used in exactly one place, fs/proc/kcore.c and the associated Kconfig is explicitly marked if !ARM. Nearly all other archs minus x86, arm64 and sparc are in the same boat as well.

Thanks,
Laura

Laura,
Can we remove it then as it seems that it's not needed at all. Cheers Nick