Skip to contentSkip to conversation

Legacy Code in gpmc-onenand.c

DISCUSSION nick 3 participants 3 messages Sep 28, 2014

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Kevin and others,
I am wondering if the below code is legacy I can remove it as stated it the fix me. Cheers Nick

else {
                /*
                * FIX ME: Appears to be legacy code from initial ONENAND commit.
                * Unclear what boards this is for and if this can be removed.
                 */
                if (!cpu_is_omap34xx())
                        onenand_sync.wait_on_read = true;
        }
#1 lore raw
Quoted 3 lines · nick

Greetings Kevin and others,
I am wondering if the below code is legacy I can remove it as stated it the fix me. Cheers Nick

Nick, could you take that to more appropriate forum? alt.sex.fetish.FIXME would probably be a good starting point...

#2 lore raw
In reply to nick
Quoted 11 lines · nick

Greetings Kevin and others,
I am wondering if the below code is legacy I can remove it as stated it the fix me. Cheers Nick

else {
                /*
                * FIX ME: Appears to be legacy code from initial ONENAND commit.
                * Unclear what boards this is for and if this can be removed.
                 */
                if (!cpu_is_omap34xx())
                        onenand_sync.wait_on_read = true;
        }

the FIX ME does not say that you can remove the code. It says you need to find out that the code is being used by which board. And if you want to remove it then you have to explain why the code is removed , and after removing what will be the effect , and if there is no effect then why there is no effect.

Good Luck.

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/