Skip to contentSkip to conversation

drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

PATCH Applied Chen Gang 2 participants 3 messages Oct 4, 2014 – Oct 6, 2014 PWM

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +1 -1
index 3865dfb..de1ffb5 100644
@@ -82,7 +82,7 @@ config PWM_BFIN
 
 config PWM_CLPS711X
 	tristate "CLPS711X PWM support"
-	depends on ARCH_CLPS711X || COMPILE_TEST
+	depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Generic PWM framework driver for Cirrus Logic CLPS711X.
Signature · 1 line
1.9.3
Applied
#1 lore raw
Quoted 17 lines · Chen Gang

PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +0 -0
index 3865dfb..de1ffb5 100644

drivers/pwm/Kconfig config PWM_BFIN · line 85

Quoted 5 lines
drivers/pwm/Kconfig +1 -1
@@ -82,7 +82,7 @@ config PWM_BFIN
 
 config PWM_CLPS711X
 	tristate "CLPS711X PWM support"
-	depends on ARCH_CLPS711X || COMPILE_TEST
+	depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM

Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of its own. This is in my opinion (slightly) more readable and matches what we already have for other drivers.

Thierry

author
#2 lore raw
Quoted 19 lines · Thierry Reding
Quoted 18 lines · Chen Gang

PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +0 -0
index 3865dfb..de1ffb5 100644
@@ -82,7 +82,7 @@ config PWM_BFIN
Quoted 9 lines

drivers/pwm/Kconfig config PWM_BFIN · line 85

Quoted 4 lines
drivers/pwm/Kconfig +1 -1
 config PWM_CLPS711X
 	tristate "CLPS711X PWM support"
-	depends on ARCH_CLPS711X || COMPILE_TEST
+	depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM

Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of its own. This is in my opinion (slightly) more readable and matches what we already have for other drivers.

It is OK to me, thank you for your work.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed