Intel DRM Driver - Weathered Colours Patch
Subsystems (2)
Hello All,
Please find a proposed workaround patch for a weathered colours (incorrect assignment to Limited RGB setting) issue. The weathered colour issue is documented at:
https://bugs.archlinux.org/task/46472
https://wiki.archlinux.org/index.php/Intel_graphics#Weathered_colors_.28color_range_problem.29
https://losca.blogspot.com.au/2013/11/workaround-for-setting-full-rgb-when.html
This patch, which I have shared with Jesse Barnes, provides a kernel command line option "i915.rgb_mode" with two usable options:
i915.rgb_mode=1 gives forced Full RGB Mode;
i915.rgb_mode=2 gives forced Limited RGB Mode.
Any other value passed to i915.rgb_mode will call the default Automatic RGB mode.
A limitation of this patch is that the KMS framebuffer needs to be interrupted, such as occurs when xorg-server starts.
i.e. if xorg-server were not to be started, the weathered colour issue remains in effect, even with a switch from one tty to another. For reference, the machine that I am testing on is a 4770k (Haswell, Core i7).
I am investigating the issue further to improve this workaround so that the change from KMS to xorg-server is not required for the patch to come into effect.
I have tested this patch on Debian Testing.
-Damien Sticklen
drivers/gpu/drm/i915/i915_params.c +5 -0
@@ -54,6 +54,7 @@ .verbose_state_checks = 1, .nuclear_pageflip = 0, .edp_vswing = 0, + .rgb_mode = 0, .enable_guc_loading = 0, .enable_guc_submission = 0, .guc_log_level = -1,
@@ -200,6 +201,10 @@"(0=use value from vbt [default], 1=low power swing(200mV)," "2=default swing(400mV))"); +/* Override for the RGB Mode Auto detection that was introduced in Linux 3.8. This will provide the user with FULL, and LIMITED on the kernel commandline */ +module_param_named (rgb_mode, i915.rgb_mode, int,0400 ); +MODULE_PARM_DESC (rgb_mode,"Override RGB Mode (1=Full RGB MODE, 2=Limited RGB Mode; Default: 0 (Automatic RGB Mode - Lets the driver select))" ); +module_param_named_unsafe (enable_guc_loading, i915.enable_guc_loading, int,0400 );MODULE_PARM_DESC (enable_guc_loading, "Enable GuC firmware loading "
drivers/gpu/drm/i915/i915_params.h +1 -0
@@ -51,6 +51,7 @@int use_mmio_flip;int mmio_debug;int edp_vswing; +int rgb_mode;/* Do not allow the kernel to select the output color width */ unsigned int inject_load_failure;/* leave bools at the end to not create holes */ bool enable_hangcheck;
drivers/gpu/drm/i915/intel_hdmi.c +15 -0
@@ -1585,7 +1585,22 @@ goto done; } +/* Implement the RGB Override specified on the kernel command line*/ if (property == dev_priv->broadcast_rgb_property) { +if (i915.rgb_mode ==1 ) { + intel_hdmi->color_range_auto = false; + intel_hdmi->limited_color_range = false; + + goto done; + } +else if (i915.rgb_mode ==2 ) { + intel_hdmi->color_range_auto = false; + intel_hdmi->limited_color_range = true; + + goto done; + } + +/* If an override option is not provided in the kernel commandline, let the driver select the mode */ bool old_auto = intel_hdmi->color_range_auto;bool old_range = intel_hdmi->limited_color_range;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for Intel DRM Driver - Weathered Colours Patch
== Series Details ==
== Series Details ==
Series: Intel DRM Driver - Weathered Colours Patch
URL : https://patchwork.freedesktop.org/series/14077/
State : warning
== Summary ==
Series 14077v1 Intel DRM Driver - Weathered Colours Patch
https://patchwork.freedesktop.org/api/1.0/series/14077/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-skl-6700hq)
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-skl-6700hq)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (fi-skl-6700hq)fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30 fi-byt-j1900 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-byt-n2820 total:246 pass:211 dwarn:0 dfail:0 fail:0 skip:35 fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:246 pass:185 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24 fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23 fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24 fi-skl-6770hq total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2771/
0b12b48da3bc580102665ee9efd7e834f6def00f drm-intel-nightly: 2016y-10m-20d-07h-52m-31s UTC integration manifest ac4a8d0 Intel DRM Driver - Weathered Colours Patch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx