Skip to contentSkip to conversation

ocfs2: do not fallback to buffer I/O write if appending

PATCH New WeiWei Wang 1 participant 1 message Oct 11, 2014 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH v4 6/7 ocfs2: do not fallback to buffer I/O write if appending

Now we can do direct io and do not fallback to buffered IO any more in case of append O_DIRECT write.

---
 fs/ocfs2/file.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/ocfs2/file.c +4 -1
index 964d442..19e372f 100644
@@ -2110,6 +2110,9 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
 	struct dentry *dentry = file->f_path.dentry;
 	struct inode *inode = dentry->d_inode;
 	loff_t saved_pos = 0, end;
+	struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
+	int full_coherency = !(osb->s_mount_opt &
+			OCFS2_MOUNT_COHERENCY_BUFFERED);
 
 	/*
 	 * We start with a read level meta lock and only jump to an ex
@@ -2198,7 +2201,7 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
 		 * one node could wind up truncating another
 		 * nodes writes.
 		 */
-		if (end > i_size_read(inode)) {
+		if (end > i_size_read(inode) && !full_coherency) {
 			*direct_io = 0;
 			break;
 		}
Signature · 1 line
1.8.4.3