Skip to contentSkip to conversation

Completion of error handling

Powertop SF Markus Elfring 1 participant 1 message Oct 18, 2014

lore
Share & tools
lore

SF Markus Elfring

author
#0 lore raw

Hello,

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?
- fputs ⇒ finish_report_output

https://github.com/fenrus75/powertop/blob/79123b34cf2cac2edeb918087dfc73f7b219cf54/src/report/report.cpp#L200

- pthread_create ⇒ cpu_calibration

https://github.com/fenrus75/powertop/blob/cdff23d6e40e31a68286a51e3c94c8a901a74091/src/calibrate/calibrate.cpp#L252

- pthread_join ⇒ extech_power_meter::end_measurement

https://github.com/fenrus75/powertop/blob/a5465a282107da5205b7928fe4ce4f642d1fd770/src/measurement/extech.cpp#L328

Regards,
Markus