checkpatch false positive
Quoted 15 lines · Hans de Goede
Hi,
Checkpatch gives the following warning:
WARNING: added, moved or deleted file(s), does
MAINTAINERSneed updating? #31:
new file mode 100644total: 0 errors, 1 warnings, 352 lines checked
0001-input-Add-new-sun4i-lradc-keys-driver.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS.
Quoted 6 lines
On a patch of mine, even though it updates
MAINTAINERSproperly, it would be nice if checkpatch would check for a hunk updatingMAINTAINERS, and then would not issue this warning (note my perl-foo is way too weak to fix this myself).I've attached the patch triggering the warning.
Hi Hans.
It's not really fixable. Of course you are welcome to try though.
Many patches are discrete and the entire series isn't visible to a single MAINTAINERS update scan by checkpatch.
Hi,
Quoted 23 lines · Joe Perches
Quoted 15 lines · Hans de Goede
Hi,
Checkpatch gives the following warning:
WARNING: added, moved or deleted file(s), does
MAINTAINERSneed updating? #31:
new file mode 100644total: 0 errors, 1 warnings, 352 lines checked
0001-input-Add-new-sun4i-lradc-keys-driver.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS.Quoted 6 lines
On a patch of mine, even though it updates
MAINTAINERSproperly, it would be nice if checkpatch would check for a hunk updatingMAINTAINERS, and then would not issue this warning (note my perl-foo is way too weak to fix this myself).I've attached the patch triggering the warning.
Quoted 7 lines
Hi Hans.
It's not really fixable. Of course you are welcome to try though.
Many patches are discrete and the entire series isn't visible to a single
MAINTAINERSupdate scan by checkpatch.
I understand that in that scenario it is not fixable, but in the case I was talking about the addition of the new file and the MAINTAINERS update are part of a single patch (adding a small new driver), it would be nice if at least in that case checkpatch would not complain. This does not even need to be really smart, it could just check if a patch introducing new files is touching MAINTAINERS at all, and if it does suppress the warning.
As said my perl-foo is weak, so I will not be trying to fix this myself.
Regards,
Hans