Skip to contentSkip to conversation

xfsprogs: two more completely harmless sparse nits

PATCH In review Eric Sandeen 2 participants 2 messages Oct 23, 2014 – Oct 27, 2014

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 xfsprogs: two more completely harmless sparse nits

Signed-off-by Eric Sandeen <[email protected]>

---

repair/prefetch.c +1 -1
index 65f8456..7ea0d36 100644
@@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
 	struct xfs_buf_map	map_array[MAP_ARRAY_SZ];
 	struct xfs_buf_map	*map = map_array;
 	int			max_extents = MAP_ARRAY_SZ;
-	int			nmaps = 0;;
+	int			nmaps = 0;
 	unsigned int		len = 0;
 	int			ret = 0;
rtcp/xfs_rtcp.c +1 -1
index b81b1e1..5f26a62 100644
@@ -25,7 +25,7 @@ int pflag;
 char *progname;
 
 void
-usage()
+usage(void)
 {
 	fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), progname);
 	exit(2);

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>

---

Reviewed-by Brian Foster <[email protected]>
Quoted 28 lines
repair/prefetch.c +1 -1
index 65f8456..7ea0d36 100644
@@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
 	struct xfs_buf_map	map_array[MAP_ARRAY_SZ];
 	struct xfs_buf_map	*map = map_array;
 	int			max_extents = MAP_ARRAY_SZ;
-	int			nmaps = 0;;
+	int			nmaps = 0;
 	unsigned int		len = 0;
 	int			ret = 0;
rtcp/xfs_rtcp.c +1 -1
index b81b1e1..5f26a62 100644
@@ -25,7 +25,7 @@ int pflag;
 char *progname;
 
 void
-usage()
+usage(void)
 {
 	fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), progname);
 	exit(2);
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs