Skip to contentSkip to conversation

iio:humidity:si7020: fix pointer to i2c client

PATCH In review Hartmut Knaack 2 participants 2 messages Oct 25, 2014 IIO

lore
Share & tools
lore

Hartmut Knaack

author
#0 lore raw

PATCH 1/1 iio:humidity:si7020: fix pointer to i2c client

In si7020_read_raw() the pointer to the i2c client was obtained as second level pointer, although a simple pointer is appropriate.

Signed-off-by Hartmut Knaack <[email protected]>

---

drivers/iio/humidity/si7020.c +2 -2
index e336af7..62d74d3 100644
@@ -45,12 +45,12 @@ static int si7020_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan, int *val,
 			   int *val2, long mask)
 {
-	struct i2c_client **client = iio_priv(indio_dev);
+	struct i2c_client *client = iio_priv(indio_dev);
 	int ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
-		ret = i2c_smbus_read_word_data(*client,
+		ret = i2c_smbus_read_word_data(client,
 					       chan->type == IIO_TEMP ?
 					       SI7020CMD_TEMP_HOLD :
 					       SI7020CMD_RH_HOLD);
maintainer
#1 lore raw
Quoted 4 lines · Hartmut Knaack

In si7020_read_raw() the pointer to the i2c client was obtained as second level pointer, although a simple pointer is appropriate.

Signed-off-by Hartmut Knaack <[email protected]>

What I'd neglected (being a forgetful soul) is that we only just took this driver anyway so the two patches will both end up in togreg whatever.

So applied to the togreg branch of iio.git - initially pushed out as testing etc etc.

Jonathan

Quoted 26 lines

---

drivers/iio/humidity/si7020.c +2 -3
index e336af7..62d74d3 100644
@@ -45,12 +45,12 @@ static int si7020_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan, int *val,
 			   int *val2, long mask)
 {
-	struct i2c_client **client = iio_priv(indio_dev);
+	struct i2c_client *client = iio_priv(indio_dev);
 	int ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
-		ret = i2c_smbus_read_word_data(*client,
+		ret = i2c_smbus_read_word_data(client,
 					       chan->type == IIO_TEMP ?
 					       SI7020CMD_TEMP_HOLD :
 					       SI7020CMD_RH_HOLD);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html