staging: skein: skein_api.c: removed space before ','

PATCH In review Mikael Svantesson 4 participants 12 messages Oct 28, 2014 – Oct 30, 2014 1 message not in the archive Staging

lore

Share & tools

lore

Mikael Svantesson

author

2014-10-28 20:08 UTC #0 lore raw

PATCH v2 1/1 staging: skein: skein_api.c: removed space before ','

Signed-off-by Mikael Svantesson <[email protected]>

---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -0

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;

Signature · 1 line

2.1.1

Sudip Mukherjee

2014-10-29 05:25 UTC #1 lore raw

Quoted 1 line · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>

still the same problem.

ERROR: patch seems to be corrupt (line wrapped?)

Quoted 23 lines

---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -0

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;

Signature · 7 lines

2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Mikael Svantesson

author

2014-10-29 07:15 UTC #2 lore raw

I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it.

The problem seems to be that Thunderbird thrashes empty lines when double clicking the e-mail in Drafts or selecting "Edit as new". When forwarding the e-mail it doesn't seem to affect the empty lines, very weird behaviour.

Regards,

Mikael

Quoted 30 lines · Sudip Mukherjee

Quoted 1 line · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>

still the same problem.

ERROR: patch seems to be corrupt (line wrapped?)

Quoted 23 lines

---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -0

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;

Signature · 7 lines

2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Mikael Svantesson

author

2014-10-29 07:26 UTC #3 lore raw

Signed-off-by Mikael Svantesson <[email protected]>

---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -1

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;

Signature · 1 line

2.1.1

Quoted 44 lines · Mikael Svantesson

I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it.
The problem seems to be that Thunderbird thrashes empty lines when double clicking the e-mail in Drafts or selecting "Edit as new". When forwarding the e-mail it doesn't seem to affect the empty lines, very weird behaviour.
Regards,
Mikael
Quoted 30 lines · Sudip Mukherjee
Quoted 1 line · Mikael Svantesson
Signed-off-by Mikael Svantesson <[email protected]>
still the same problem.
ERROR: patch seems to be corrupt (line wrapped?)
Quoted 23 lines
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/skein/skein_api.c +1 -0
index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;
Signature · 7 lines
2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Sudip Mukherjee

2014-10-29 08:06 UTC #8 lore raw

In reply to Mikael Svantesson

Quoted 2 lines · Mikael Svantesson

I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it.

any particular reason that you are not sending it using git send-email ?

Quoted 42 lines

The problem seems to be that Thunderbird thrashes empty lines when double clicking the e-mail in Drafts or selecting "Edit as new". When forwarding the e-mail it doesn't seem to affect the empty lines, very weird behaviour.
Regards,
Mikael
Quoted 30 lines · Sudip Mukherjee
Quoted 1 line · Mikael Svantesson
Signed-off-by Mikael Svantesson <[email protected]>
still the same problem.
ERROR: patch seems to be corrupt (line wrapped?)
Quoted 23 lines
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/skein/skein_api.c +1 -0
index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;
Signature · 7 lines
2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Greg Kroah-Hartman

maintainer

2014-10-29 15:47 UTC #9 lore raw

In reply to Mikael Svantesson

Quoted 10 lines · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/skein/skein_api.c +0 -0
index 6e700ee..5bfce07 100644

drivers/staging/skein/skein_api.c int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size) · line 34

Quoted 4 lines

drivers/staging/skein/skein_api.c +1 -0

@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));

Still corrupted, what added the extra ' ' before the '-'?

Mikael Svantesson

author

2014-10-29 15:57 UTC #10 lore raw

Quoted 6 lines · Greg Kroah-Hartman

Quoted 5 lines · Mikael Svantesson
Signed-off-by Mikael Svantesson <[email protected]>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 12 lines

drivers/staging/skein/skein_api.c int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size) · line 34
Quoted 9 lines
drivers/staging/skein/skein_api.c +1 -0
index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
Still corrupted, what added the extra ' ' before the '-'?

Thunderbird builtin editor, I guess. Can't remember why I decided to do it that way instead of git-send-email.

I replied to my other explanation with a non-corrupt patch but I can submit it as v3 instead if that's preferable.

/ Mikael

Greg Kroah-Hartman

maintainer

2014-10-29 16:07 UTC #4 lore raw

In reply to Mikael Svantesson

Quoted 66 lines · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/skein/skein_api.c +1 -1
index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;
Signature · 1 line
2.1.1
Quoted 38 lines · Mikael Svantesson
I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it.
The problem seems to be that Thunderbird thrashes empty lines when double clicking the e-mail in Drafts or selecting "Edit as new". When forwarding the e-mail it doesn't seem to affect the empty lines, very weird behaviour.
Regards,
Mikael
Quoted 25 lines · Sudip Mukherjee
Quoted 1 line · Mikael Svantesson
Signed-off-by Mikael Svantesson <[email protected]>
still the same problem.
ERROR: patch seems to be corrupt (line wrapped?)
Quoted 18 lines
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/skein/skein_api.c +1 -0
index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;
Signature · 1 line
2.1.1
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Please send this as a "correct" patch, not one with a whole bunch of other stuff in it that I would have to hand-edit in order to apply properly.

Remember, you want to make it as easy as possible for me to accept your patches, so far, this isn't going well :)

greg k-h

Mikael Svantesson

author

2014-10-29 16:39 UTC #5 lore raw

Quoted 9 lines · Greg Kroah-Hartman

Please send this as a "correct" patch, not one with a whole bunch of other stuff in it that I would have to hand-edit in order to apply properly.
Remember, you want to make it as easy as possible for me to accept your patches, so far, this isn't going well :)
greg k-h

Yeah, sorry about that. I have no idea why I haven't just used git-send-email.

I'll reply to this e-mail with a (hopefully) correct e-mail, otherwise I'll just give up, this is starting to get too embarassing. :D

/ Mikael

Mikael Svantesson

author

2014-10-29 17:46 UTC #6 lore raw

PATCH 1/1 staging: skein: skein_api.c: removed space before ','

Signed-off-by Mikael Svantesson <[email protected]>

---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -1

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;

Signature · 1 line

2.1.1

Jason Cooper

Acked-by

2014-10-29 17:51 UTC #12 lore raw

In reply to a message not in the archive

Mikael,

Quoted 4 lines · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by Jason Cooper <[email protected]>

For future patches, please remember to add the 'V3' to the subject like you did for v2.

thx,

Jason.

Sudip Mukherjee

2014-10-30 05:45 UTC #7 lore raw

In reply to Mikael Svantesson

Quoted 2 lines · Mikael Svantesson

Signed-off-by Mikael Svantesson <[email protected]>
---

better to send this as a new thread and start the subject as [PATCH v3]
and also mention a commit message.

thanks
sudip

Quoted 24 lines

 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/skein/skein_api.c +1 -1

index 6e700ee..5bfce07 100644
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;

Signature · 7 lines

2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/