Skip to contentSkip to conversation

saquery.c: Fix handling of cpi and ClassPortInfo options

PATCH Applied Hal Rosenstock 2 participants 2 messages Nov 5, 2014 – Nov 8, 2014 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 saquery.c: Fix handling of cpi and ClassPortInfo options

Need to check if query_type is CLASS_PORT_INFO
in order to handle saquery [cpi | ClassPortInfo].
Otherwise, it just dumps ClassPortInfo attribute
as all 0s.

Note that saquery -c works fine because it
set command to SAQUERY_CMD_CLASS_PORT_INFO.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

src/saquery.c +1 -0
index 0f39064..1af3401 100644
@@ -1869,6 +1869,7 @@ int main(int argc, char **argv)
 		params.dlid = get_lid(h, dst_lid);
 
 	if (command == SAQUERY_CMD_CLASS_PORT_INFO ||
+	    query_type == CLASS_PORT_INFO ||
 	    query_type == IB_SA_ATTR_SWITCHINFORECORD)
 		sa_cpi_required = 1;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 545A86E3.4050000-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Sent: Wednesday, November 05, 2014 12:22 PM
To: Weiny, Ira
Cc: linux-rdma ([email protected]); Doug Ledford; Dan Ben-Yosef
Subject: [PATCH infiniband-diags] saquery.c: Fix handling of cpi and ClassPortInfo options

Quoted 8 lines

Need to check if query_type is CLASS_PORT_INFO in order to handle saquery [cpi | ClassPortInfo].
Otherwise, it just dumps ClassPortInfo attribute as all 0s.

Note that saquery -c works fine because it set command to SAQUERY_CMD_CLASS_PORT_INFO.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks applied,
Ira

src/saquery.c int main(int argc, char **argv) · line 1875

Quoted 12 lines

---

src/saquery.c +1 -0
@@ -1869,6 +1869,7 @@ int main(int argc, char **argv)
 		params.dlid = get_lid(h, dst_lid);
 
 	if (command == SAQUERY_CMD_CLASS_PORT_INFO ||
+	    query_type == CLASS_PORT_INFO ||
 	    query_type == IB_SA_ATTR_SWITCHINFORECORD)
 		sa_cpi_required = 1;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html