Skip to contentSkip to conversation

FIX MEs for spinlocks in drbd_worker.c

DRBD-user Lars Ellenberg 1 participant 1 message Nov 22, 2014 1 message not in the archive DRBD driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Lars Ellenberg

author maintainer
#1 lore raw
Quoted 5 lines · nick

Greetings Lars,
I am wondering about removing the spin locks around the linked list operators in worker.c or do we need to test it first it first on actual hardware.
Cheers Nick

Unless you have deep insight in the inner workings of DRBD and their interactions, I'd strongly recommend to go find some other fixmes.

That is much more complicated than just removing those lines and hope for the best. Otherwise they would not be there (and not FIXME tag to find them).

Maybe you just want to reverse-sort your grep for fixmes, so that the bottom of the list gets some love, too.

Thanks,
Lars