Fix PXA2xx RTC, interrupts before register ioremap

PATCH New Petr Cvek 1 participant 1 message Nov 24, 2014 Real time clock (RTC)

lore

Share & tools

lore

Petr Cvek

author

2014-11-24 04:31 UTC #0 lore raw

PATCH 1/1 Fix PXA2xx RTC, interrupts before register ioremap

Fix commits:

a44802f8fb7e593adabc6ef53c8df45a1717fa9b drivers/rtc/rtc-pxa.c: fix alarm can't wake up system issue 2f6e5f9458646263d3d9ffadd5e11e3d8d15a7d0 drivers/rtc: remove IRQF_DISABLED

Interrupts appear before registers of the RTC controller are ioremapped.

Signed-off-by Petr Cvek <[email protected]>

---
 drivers/rtc/rtc-pxa.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

drivers/rtc/rtc-pxa.c +5 -1

index 4561f37..d7d83e5 100644
@@ -346,7 +346,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
 		dev_err(dev, "No alarm IRQ resource defined\n");
 		return -ENXIO;
 	}
-	pxa_rtc_open(dev);
+
 	pxa_rtc->base = devm_ioremap(dev, pxa_rtc->ress->start,
 				resource_size(pxa_rtc->ress));
 	if (!pxa_rtc->base) {

@@ -375,6 +375,10 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
 		return ret;
 	}
 
+	ret = pxa_rtc_open(dev);
+	if (ret)
+		return ret;
+
 	device_init_wakeup(dev, 1);
 
 	return 0;

Signature · 1 line

1.7.12.1