ovl: Cleanup redundant blank lines
PATCH 1/1 ovl: Cleanup redundant blank lines
This patch removes redundant blanks lines in overlayfs.
--- fs/overlayfs/copy_up.c | 1 - fs/overlayfs/inode.c | 1 - fs/overlayfs/super.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
fs/overlayfs/copy_up.c +0 -1
@@ -191,7 +191,6 @@ int ovl_set_attr(struct dentry *upperdentry, struct kstat *stat)ovl_set_timestamps (upperdentry, stat);return err; - } static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir,
fs/overlayfs/inode.c +0 -1
@@ -430,5 +430,4 @@ struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, }return inode; - }
fs/overlayfs/super.c +0 -1
@@ -98,7 +98,6 @@ void ovl_path_upper(struct dentry *dentry, struct path *path)enum ovl_path_type ovl_path_real (struct dentry *dentry,struct path *path) { -enum ovl_path_type type =ovl_path_type (dentry);if (type ==OVL_PATH_LOWER )
Signature · 1 line
1.6.0.2
Hi Miklos,
Will you apply my previous patch "ovl: Use macros to present ovl_xattr"? These two patches(previous one and this one) are based on branch *overlayfs-current* and conflict with each other.
I don't know which branch I should use, overlayfs-current or overlayfs-next. How could I join the development?
By the way, do you think we can make use of "kmem_cache" to manage "struct ovl_entry"? I think it will speedup operations like *ls*. I saw your work about multi-layer support. The size of "struct ovl_entry" will be variable. In addition, some free paths of ovl_entry rely on RCU. So maybe it's not easy.
Thanks~!
Hu
Miklos Szeredi
maintainerQuoted 9 lines · hujianyang
Hi Miklos,
Will you apply my previous patch "ovl: Use macros to present
ovl_xattr"? These two patches(previous one and this one) are based on branch *overlayfs-current* and conflict with each other.I don't know which branch I should use, overlayfs-current or overlayfs-next. How could I join the development?
If it's a bugfix, then do it against -current. If it's a cleanup patch, like the one you did, do it against -next.
Quoted 5 lines
By the way, do you think we can make use of "
kmem_cache" to manage "structovl_entry"? I think it will speedup operations like *ls*. I saw your work about multi-layer support. The size of "structovl_entry" will be variable. In addition, some free paths ofovl_entryrely on RCU. So maybe it's not easy.
With the multi-layer support in overlayfs-next "struct ovl_entry" becomes variable sized, so we can't use kmem_cache for it.
Thanks,
Miklos