Skip to contentSkip to conversation

Non Explained TODOs in halbtcoutsrc.c

DISCUSSION Larry Finger 1 participant 2 messages Nov 30, 2014 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines · nick

Greetings Larry,
After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this file, it would be nice to hear from you on why they are needed as TODO as a comment is rather unclear for anybody reading this file.
Nick

I did not write that code. I merely make it available through the git repo, and modify it so that it will build on all kernel versions. I do not understand the TODOs any more than you do.

Larry

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 7 lines · nick

Larry,
Do you known who wrote that code as this I can email them for the explanations for them. If not I assume we can remove them as the code makes logical sense unless there are hardware or other quirks that need to be handled. :)
Cheers and Thanks for Your Time,
Nick

Quoted 12 lines
Quoted 11 lines · Larry Finger
Quoted 6 lines · nick

Greetings Larry,
After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this file, it would be nice to hear from you on why they are needed as TODO as a comment is rather unclear for anybody reading this file.
Nick

I did not write that code. I merely make it available through the git repo, and modify it so that it will build on all kernel versions. I do not understand the TODOs any more than you do.

Larry

Sorry, I do not have permission to reveal the E-mail addresses of any Realtek software developers. I have added the appropriate developer as a Bcc to this E-mail. That will leave it up to that individual to respond to you.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html