Skip to contentSkip to conversation

Another FIXME in libata-scsi.c

DISCUSSION Tejun Heo 1 participant 2 messages Dec 4, 2014 2 messages not in the archive libata

lore
Share & tools
lore

Tejun Heo

author
#1 lore raw
In reply to a message not in the archive
Quoted 2 lines · nick

Greetings again Tejun,
I am wondering about if the code needs improvement as it seems to not from my reading.

The comment doesn't serve any purpose but it's not harming anything either. I'd just leave it alone.

Thanks.

Signature · 1 line
tejun
author
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · nick

Are you sure as it seems FIX MES mean unfinished work and issues. I would personally remove the FIX ME part at least.

It really doesn't matter unless it's actively misleading. If you have good enough justification that the comment is unnecessary / misleading, please feel free to submit a patch with accompanying rationales but it's not something we should spend time and energy collaborating on.

Thanks.

Signature · 1 line
tejun