ppc64 and Documentation/mic/mpssd/mpssd.c issues

DISCUSSION Daniel Borkmann 5 participants 6 messages Dec 4, 2014

lore

Share & tools

lore

Daniel Borkmann

author

2014-12-04 13:41 UTC #0 lore raw

Hi Caz,

I think commit ...

commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e

Author: Caz Yokoyama <[email protected]>
Date:   Thu Sep 5 16:42:39 2013 -0700

Sample Implementation of Intel MIC User Space Daemon.

... actually triggers a build error on my default config ppc64 (I'm using net-next tree):

HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2

gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)

Cheers,
Daniel

Sudeep Dutt

2014-12-04 16:58 UTC #2 lore raw

In reply to Yokoyama, Caz

Quoted 4 lines · Caz

Thank you for the report.
Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X?
MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X.

I am adding Peter Foley since he enabled the mpssd build by default recently with commit adb19fb. Peter, is there a way to enable the mpssd build only for x86_64?

Thanks,
Sudeep Dutt

Quoted 46 lines

Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them?
Thank you.
-caz, [email protected], [email protected]
-----Original Message-----
From: Daniel Borkmann [mailto:[email protected]]
Sent: Thursday, December 04, 2014 5:42 AM
To: Yokoyama, Caz
Cc: [email protected]; [email protected]
Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues
Hi Caz,
I think commit ...
commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e
Author: Caz Yokoyama <[email protected]>
Date:   Thu Sep 5 16:42:39 2013 -0700
Sample Implementation of Intel MIC User Space Daemon.
... actually triggers a build error on my default config ppc64 (I'm using net-next tree):
HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2
gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
Cheers,
Daniel

Yokoyama, Caz

2014-12-04 16:58 UTC #1 lore raw

In reply to Daniel Borkmann

Thank you for the report.
Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? MIC card is expected to work with x86_64 host, not with ppc64. We have neve= r compiled on ppc host while our primary development platform was rhel6.X.

Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any cha= nge on them?

Thank you.
-caz, [email protected], [email protected]

-----Original Message-----
From: Daniel Borkmann [mailto:[email protected]]=20
Sent: Thursday, December 04, 2014 5:42 AM
To: Yokoyama, Caz
Cc: [email protected]; [email protected]
Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues

Hi Caz,

I think commit ...

commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e

Author: Caz Yokoyama <[email protected]>
Date:   Thu Sep 5 16:42:39 2013 -0700

Sample Implementation of Intel MIC User Space Daemon.

... actually triggers a build error on my default config ppc64 (I'm using net-next tree):

HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression a= llowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression a= llowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression = allowed only inside a function
make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2

gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)

Cheers,
Daniel

Peter Foley

2014-12-04 17:01 UTC #3 lore raw

In reply to Sudeep Dutt

Quoted 9 lines · Sudeep Dutt

Quoted 4 lines · Caz
Thank you for the report.
Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X?
MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X.
I am adding Peter Foley since he enabled the mpssd build by default recently with commit adb19fb. Peter, is there a way to enable the mpssd build only for x86_64?

Change hostprogs-y to hostprogs-$(CONFIG_X86_64) in the mpssd Makefile. That will restrict it to x86_64 only.

Daniel Borkmann

author

2014-12-04 17:03 UTC #4 lore raw

In reply to Sudeep Dutt

Quoted 4 lines · Sudeep Dutt

Quoted 3 lines · Caz
Thank you for the report.
Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X?
MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X.

Yep, I was using RHEL6 on ppc64 by chance to build an upstream kernel.

You might want to fix the Kconfig entry then to limit this to x86_64 only. ;)

Thanks,
Daniel

Quoted 55 lines

I am adding Peter Foley since he enabled the mpssd build by default recently with commit adb19fb. Peter, is there a way to enable the mpssd build only for x86_64?
Thanks,
Sudeep Dutt
Quoted 46 lines
Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them?
Thank you.
-caz, [email protected], [email protected]
-----Original Message-----
From: Daniel Borkmann [mailto:[email protected]]
Sent: Thursday, December 04, 2014 5:42 AM
To: Yokoyama, Caz
Cc: [email protected]; [email protected]
Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues
Hi Caz,
I think commit ...
commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e
Author: Caz Yokoyama <[email protected]>
Date:   Thu Sep 5 16:42:39 2013 -0700
Sample Implementation of Intel MIC User Space Daemon.
... actually triggers a build error on my default config ppc64 (I'm using net-next tree):
HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2
gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
Cheers,
Daniel

Benjamin Herrenschmidt

2014-12-04 20:29 UTC #5 lore raw

In reply to Yokoyama, Caz

Quoted 5 lines · Caz

Thank you for the report.
Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X?
MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X.
Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them?

Then you should make sure your Kconfig/Makefile stanza only compiles it on x86_64 instead of breaking all other architectures...

Ben.

Quoted 44 lines

Thank you.
-caz, [email protected], [email protected]
-----Original Message-----
From: Daniel Borkmann [mailto:[email protected]]
Sent: Thursday, December 04, 2014 5:42 AM
To: Yokoyama, Caz
Cc: [email protected]; [email protected]
Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues
Hi Caz,
I think commit ...
commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e
Author: Caz Yokoyama <[email protected]>
Date:   Thu Sep 5 16:42:39 2013 -0700
Sample Implementation of Intel MIC User Space Daemon.
... actually triggers a build error on my default config ppc64 (I'm using net-next tree):
HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2
gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
Cheers,
Daniel