vivid: fix CROP_BOUNDS typo for video output

PATCH New Hans Verkuil 1 participant 1 message Dec 6, 2014 Media (V4L/DVB)

lore

Share & tools

lore

Hans Verkuil

author

2014-12-06 10:30 UTC #0 lore raw

PATCH 1/1 vivid: fix CROP_BOUNDS typo for video output

An error was returned if composing was not supported, instead of if cropping was not supported.

A classic copy-and-paste bug. Found with v4l2-compliance.

Signed-off-by Hans Verkuil <[email protected]>

Cc <[email protected]> # for v3.18

---
 drivers/media/platform/vivid/vivid-vid-out.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/platform/vivid/vivid-vid-out.c +1 -1

index ee5c399..39ff79f 100644
@@ -625,7 +625,7 @@ int vivid_vid_out_g_selection(struct file *file, void *priv,
 		sel->r = dev->fmt_out_rect;
 		break;
 	case V4L2_SEL_TGT_CROP_BOUNDS:
-		if (!dev->has_compose_out)
+		if (!dev->has_crop_out)
 			return -EINVAL;
 		sel->r = vivid_max_rect;
 		break;

Signature · 1 line

2.1.3