Skip to contentSkip to conversation

Bad Commit for Current Lockups

DISCUSSION nick 3 participants 3 messages Dec 11, 2014

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings,
I send Dave, what I feel is the bad commit for the current lockups found in kernel 3.18 r4. The bad commit I believe is 4995ab9cf512e9a6cc07dfd6b1d4e2fc48ce7fef as it does touch the TLB code in the function that is most likely causing issues. Nick

#1 lore raw

Did you test this theory or just do a simple search and make an assumption? Did you test before and after reverting the patch?

You cant just make a statement without backing it up.

Chris

Quoted 8 lines · nick

Greetings,
I send Dave, what I feel is the bad commit for the current lockups found in kernel 3.18 r4. The bad commit I believe is 4995ab9cf512e9a6cc07dfd6b1d4e2fc48ce7fef as it does touch the TLB code in the function that is most likely causing issues. Nick

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

#2 lore raw
In reply to nick
Quoted 3 lines · nick

I send Dave, what I feel is the bad commit for the current lockups found in kernel 3.18 r4. The bad commit I believe is 4995ab9cf512e9a6cc07dfd6b1d4e2fc48ce7fef as it does touch the TLB code in the function that is most likely causing issues.

Have you actually confirmed this with a git bisect, and/or tested with this commit reverted on a system that easily locks up, or have a good explanation why the TLB code is at fault, or what function you think is most likely causing issues, and why?

Bonus points for explaining *why* the code refactoring in that commit is wrong.

/me makes popcorn. This should be interesting....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141211/914a7e60/attachment-0001.bin