Skip to contentSkip to conversation

Question about Old Fix Me comment in mempool.c

DISCUSSION nick 2 participants 2 messages Dec 17, 2014 – Feb 25, 2015 Memory management

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Andrew and other maintainers,
I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now. /*
* FIXME: this should be io_schedule(). The timeout is there as a
* workaround for some DM problems in 2.6.18.
*/

Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).

Thanks for Your Time,
Nick

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 11 lines · nick

Greetings Andrew and other maintainers,
I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now. /*
* FIXME: this should be io_schedule(). The timeout is there as a
* workaround for some DM problems in 2.6.18.
*/

Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).

Thanks for Your Time,
Nick

There are still some bugs with respect to this (and they will probably never be removed all) - for example this bug which wasn't fixed yet
http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html .

So, you should not remove it.

Mikulas

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>