Skip to contentSkip to conversation

Testing preemptibility test in xen_setup_cpu_clockevents()

DISCUSSION Boris Ostrovsky 2 participants 3 messages Dec 22, 2014

lore
Share & tools
lore
#0 lore raw

With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in native_smp_prepare_cpus()) HVM guests no longer boot since we are hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().

I don't think we need this test (PV or HVM), do we?

-boris

#1 lore raw
Quoted 5 lines · Boris Ostrovsky

With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in native_smp_prepare_cpus()) HVM guests no longer boot since we are hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().

I don't think we need this test (PV or HVM), do we?

It looks safe to remove the BUG_ON().

David

#2 lore raw
In reply to Boris Ostrovsky
Quoted 5 lines · Boris Ostrovsky

With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in native_smp_prepare_cpus()) HVM guests no longer boot since we are hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().

I don't think we need this test (PV or HVM), do we?

It looks safe to remove the BUG_ON().

David