Skip to contentSkip to conversation

Commit f5b2831d65 cause boot failure in VMware ESXi 5.1 guest

REGRESSION Qu Wenruo 3 participants 4 messages Dec 26, 2014 – Dec 29, 2014

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

Hi all,

When testing v3.19-rc1 kernel(in fact, try to test), the kernel itself fail to boot on VMware ESXi 5.1 guest. The boot failure is quite easy to describe, only one line is output:
"Probing EDD (edd=off to disable)...ok"

No other output(including warning/bug_on/backtrace or whatever) and the guest just hangs. It's OK on v3.18, so it's a regression.

Bisect points to the following commit:
commit f5b2831d654167d77da8afbef4d2584897b12d0c

Author: Juergen Gross <[email protected]>
Date:   Mon Nov 3 14:02:02 2014 +0100

x86: Respect PAT bit when copying pte values between large and
normal pages

The PAT bit in the ptes is not moved to the correct position when copying page protection attributes between entries of different sized pages. Translate the ptes according to their page size.

I have also created the kernel BZ report:
https://bugzilla.kernel.org/show_bug.cgi?id=90321

Hopes this can be resolved in next rc.

Thanks,
Qu

#1 lore raw

[ +to Thomas Hellstrom ]

Quoted 3 lines · Qu Wenruo

Hi all,

When testing v3.19-rc1 kernel(in fact, try to test), the kernel itself fail to boot on VMware ESXi 5.1 guest.

Maybe this problem related to the other VMware PAT issue?

Quoted 25 lines

The boot failure is quite easy to describe, only one line is output:
"Probing EDD (edd=off to disable)...ok"

No other output(including warning/bug_on/backtrace or whatever) and the guest just hangs. It's OK on v3.18, so it's a regression.

Bisect points to the following commit:
commit f5b2831d654167d77da8afbef4d2584897b12d0c

Author: Juergen Gross <[email protected]>
Date:   Mon Nov 3 14:02:02 2014 +0100

x86: Respect PAT bit when copying pte values between large and normal pages

The PAT bit in the ptes is not moved to the correct position when copying page protection attributes between entries of different sized pages. Translate the ptes according to their page size.

I have also created the kernel BZ report:
https://bugzilla.kernel.org/show_bug.cgi?id=90321

Hopes this can be resolved in next rc.

Thanks,
Qu

#2 lore raw
In reply to Qu Wenruo
Quoted 24 lines · Qu Wenruo

Hi all,

When testing v3.19-rc1 kernel(in fact, try to test), the kernel itself fail to boot on VMware ESXi 5.1 guest.
The boot failure is quite easy to describe, only one line is output:
"Probing EDD (edd=off to disable)...ok"

No other output(including warning/bug_on/backtrace or whatever) and the guest just hangs.
It's OK on v3.18, so it's a regression.

Bisect points to the following commit:
commit f5b2831d654167d77da8afbef4d2584897b12d0c

Author: Juergen Gross <[email protected]>
Date:   Mon Nov 3 14:02:02 2014 +0100

x86: Respect PAT bit when copying pte values between large and
normal pages

The PAT bit in the ptes is not moved to the correct position when copying page protection attributes between entries of different sized pages. Translate the ptes according to their page size.

Quoted 4 lines

I have also created the kernel BZ report:
https://bugzilla.kernel.org/show_bug.cgi?id=90321

Hopes this can be resolved in next rc.

As the same issue has been reported with VMWare workstation which was related to an error in the PAT MSR emulation of VMWare, I guess this will be the same problem. I've already sent a patch.

You should be able to boot with the "nopat" kernel option.

Juergen

author
#3 lore raw

-------- Original Message --------
Subject: Re: [REGRESSION][x86] Commit f5b2831d65 cause boot failure in VMware ESXi 5.1 guest
From: Juergen Gross <[email protected]>
To: Qu Wenruo <[email protected]>
Date: 2014年12月27日 21:51

Quoted 31 lines · Qu Wenruo
Quoted 25 lines

Hi all,

When testing v3.19-rc1 kernel(in fact, try to test), the kernel itself fail to boot on VMware ESXi 5.1 guest.
The boot failure is quite easy to describe, only one line is output:
"Probing EDD (edd=off to disable)...ok"

No other output(including warning/bug_on/backtrace or whatever) and the guest just hangs.
It's OK on v3.18, so it's a regression.

Bisect points to the following commit:
commit f5b2831d654167d77da8afbef4d2584897b12d0c

Author: Juergen Gross <[email protected]>
Date:   Mon Nov 3 14:02:02 2014 +0100

x86: Respect PAT bit when copying pte values between large and
normal pages

The PAT bit in the ptes is not moved to the correct position when copying page protection attributes between entries of different
sized
pages. Translate the ptes according to their page size.

Quoted 4 lines

I have also created the kernel BZ report:
https://bugzilla.kernel.org/show_bug.cgi?id=90321

Hopes this can be resolved in next rc.

Quoted 8 lines

As the same issue has been reported with VMWare workstation which was related to an error in the PAT MSR emulation of VMWare, I guess this will be the same problem. I've already sent a patch.

You should be able to boot with the "nopat" kernel option.

Juergen

Thanks for the explanation. Again the closed source blob to blame.

Anyway, the nopat option works.

Great thanks
Qu