Skip to contentSkip to conversation

Question about FIXME in au1xxx-ide.c

DISCUSSION David Miller 1 participant 1 message Dec 30, 2014 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

From: nick <[email protected]>
Date: Tue, 30 Dec 2014 12:31:04 -0500

Quoted 10 lines

Greetings David,
I am wondering about the fix me in the file,au1xxx-ide.c for the function,auide_ddma_init. While it's obvious to check the return code of the function called below the FIXME comment,it seems to be that there is more to this issue and therefore I have a few questions. The first being can this device fail and the system will function properly? The second question being don't we need to remove the device if the allocation fails in the creation of the data structures for it's use by the kernel as otherwise aren't we leaking memory?

I have no idea why the FIXME comment is there, I didn't write this driver nor have I ever made any changes to it.