Skip to contentSkip to conversation

fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal

PATCH Applied Hal Rosenstock 2 participants 2 messages Jan 9, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH v2 1/1 fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal

for consistency with CC Annex which shows meaning of threshold fields in hex not decimal

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
Change since v1:
Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be consistent with CC Annex

src/fields.c +2 -2
index 33a6364..9965811 100644
@@ -858,9 +858,9 @@ static const ib_field_t ib_mad_f[] = {
 	{0, 32, "Control_Map", mad_dump_hex},
 	{32, 256, "Victim_Mask", mad_dump_array},
 	{288, 256, "Credit_Mask", mad_dump_array},
-	{BITSOFFS(544, 4), "Threshold", mad_dump_uint},
+	{BITSOFFS(544, 4), "Threshold", mad_dump_hex},
 	{BITSOFFS(552, 8), "Packet_Size", mad_dump_uint},
-	{BITSOFFS(560, 4), "CS_Threshold", mad_dump_uint},
+	{BITSOFFS(560, 4), "CS_Threshold", mad_dump_hex},
 	{BITSOFFS(576, 16), "CS_ReturnDelay", mad_dump_hex}, /* TODO: CCT dump */
 	{BITSOFFS(592, 16), "Marking_Rate", mad_dump_uint},
 	{0, 0},			/* IB_CC_SWITCH_CONGESTION_SETTING_LAST_F */

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 54AFB622.2010301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 4 lines

for consistency with CC Annex which shows meaning of threshold fields in hex not decimal

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks applied.

Ira

Quoted 21 lines

---
Change since v1:
Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be consistent with CC Annex

src/fields.c +2 -2
@@ -858,9 +858,9 @@ static const ib_field_t ib_mad_f[] = {
 	{0, 32, "Control_Map", mad_dump_hex},
 	{32, 256, "Victim_Mask", mad_dump_array},
 	{288, 256, "Credit_Mask", mad_dump_array},
-	{BITSOFFS(544, 4), "Threshold", mad_dump_uint},
+	{BITSOFFS(544, 4), "Threshold", mad_dump_hex},
 	{BITSOFFS(552, 8), "Packet_Size", mad_dump_uint},
-	{BITSOFFS(560, 4), "CS_Threshold", mad_dump_uint},
+	{BITSOFFS(560, 4), "CS_Threshold", mad_dump_hex},
 	{BITSOFFS(576, 16), "CS_ReturnDelay", mad_dump_hex}, /* TODO: CCT

dump */

src/fields.c +0 -0
 	{BITSOFFS(592, 16), "Marking_Rate", mad_dump_uint},
 	{0, 0},			/*
Quoted 1 line

IB_CC_SWITCH_CONGESTION_SETTING_LAST_F */

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html