Skip to contentSkip to conversation

ibdiag_common.c: Add more supported device IDs in is_mlnx_ext_port_info_supported

PATCH Applied Hal Rosenstock 2 participants 2 messages Jan 14, 2015 – Jan 19, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH v3 1/1 ibdiag_common.c: Add more supported device IDs in is_mlnx_ext_port_info_supported

Add support for some ConnectX-IB, ConnectX-4, and Switch-IB in is_mlnx_ext_port_info_supported.

This only affects tool(s) which invoke this routine (is_mlnx_ext_port_info_supported) which is currently just ibportstate.

is_mlnx_ext_port_info_supported determines whether or not the MLNX vendor extended port info SMP is sent which is used to determine FDR10 speed.

Not having the device in the list would only result in FDR10 being misinterpreted as QDR.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
Change since v2:
Changed ConnectX-3 to ConnectX-IB in patch description

Change since v1:
Improved patch description

src/ibdiag_common.c +2 -2
index 8c749c7..384d342 100644
@@ -499,9 +499,9 @@ conv_cnt_human_readable(uint64_t val64, float *val, int data)
 int is_mlnx_ext_port_info_supported(uint32_t devid)
 {
 	if (ibd_ibnetdisc_flags & IBND_CONFIG_MLX_EPI) {
-		if (devid == 0xc738)
+		if (devid == 0xc738 || devid == 0xcb84)
 			return 1;
-		if (devid >= 0x1003 && devid <= 0x1011)
+		if (devid >= 0x1003 && devid <= 0x1016)
 			return 1;
 	}
 	return 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 54B677FE.6040508-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 17 lines

-----Original Message-----
From: [email protected] [mailto:linux-rdma- [email protected]] On Behalf Of Hal Rosenstock
Sent: Wednesday, January 14, 2015 6:07 AM
To: Weiny, Ira
Cc: linux-rdma ([email protected]); Or Gerlitz
Subject: [PATCH v3 infiniband-diags] ibdiag_common.c: Add more supported device IDs in is_mlnx_ext_port_info_supported

Add support for some ConnectX-IB, ConnectX-4, and Switch-IB in is_mlnx_ext_port_info_supported.

This only affects tool(s) which invoke this routine (is_mlnx_ext_port_info_supported) which is currently just ibportstate.

Quoted 7 lines

is_mlnx_ext_port_info_supported determines whether or not the MLNX vendor extended port info SMP is sent which is used to determine FDR10 speed.

Not having the device in the list would only result in FDR10 being misinterpreted as QDR.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks, applied,
Ira

Quoted 23 lines

---
Change since v2:
Changed ConnectX-3 to ConnectX-IB in patch description

Change since v1:
Improved patch description

src/ibdiag_common.c index renamed from src/ibdiag_common.c +0 -0

8c749c7..384d342 100644

src/ibdiag_common.c +2 -3
@@ -499,9 +499,9 @@ conv_cnt_human_readable(uint64_t val64, float *val,
 int data)  int is_mlnx_ext_port_info_supported(uint32_t devid)  {
 	if (ibd_ibnetdisc_flags & IBND_CONFIG_MLX_EPI) {
-		if (devid == 0xc738)
+		if (devid == 0xc738 || devid == 0xcb84)
 			return 1;
-		if (devid >= 0x1003 && devid <= 0x1011)
+		if (devid >= 0x1003 && devid <= 0x1016)
 			return 1;
 	}
 	return 0;
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html