Skip to contentSkip to conversation

net: prevent of emerging cross-namespace symlinks patches for 3.14

DISCUSSION Miquel van Smoorenburg 2 participants 3 messages Jan 14, 2015

lore
Share & tools
lore
#0 lore raw

When running 'lxc' on the latest -stable kernel, 3.14.28, I'm seeing these errors:

Jan 14 17:47:16 lxc2 kernel: [   10.704890] WARNING: CPU: 0 PID: 3209 at fs/sys
fs/dir.c:52 sysfs_warn_dup+0x8c/0xb0()
Jan 14 17:47:16 lxc2 kernel: [   10.704892] sysfs: cannot create duplicate filename '/devices/virtual/net/eth0.104/upper_eth0'
Jan 14 17:47:16 lxc2 kernel: [   10.704954] CPU: 0 PID: 3209 Comm: lxc-autostart Not tainted 3.14.28-xsserver #1

I did not see these errors in 3.12. This was fixed in 3.17 by:

net: prevent of emerging cross-namespace symlinks
https://github.com/torvalds/linux/commit/4c75431ac3520631f1d9e74aa88407e6374dbbc4

net: fix creation adjacent device symlinks
https://github.com/torvalds/linux/commit/7ce64c79c4decdeb1afe0bf2f6ef834b382871d1

These patches apply cleanly to 3.14.28. I think this should go into 3.14-stable.

Thanks,

Mike.

#1 lore raw
Quoted 13 lines · Miquel van Smoorenburg

When running 'lxc' on the latest -stable kernel, 3.14.28, I'm seeing these errors:

Jan 14 17:47:16 lxc2 kernel: [   10.704890] WARNING: CPU: 0 PID: 3209 at
fs/sys
fs/dir.c:52 sysfs_warn_dup+0x8c/0xb0()
Jan 14 17:47:16 lxc2 kernel: [   10.704892] sysfs: cannot create duplicate
filename '/devices/virtual/net/eth0.104/upper_eth0'
Jan 14 17:47:16 lxc2 kernel: [   10.704954] CPU: 0 PID: 3209 Comm:

lxc-autostart Not tainted 3.14.28-xsserver #1

I did not see these errors in 3.12. This was fixed in 3.17 by:

Quoted 8 lines

net: prevent of emerging cross-namespace symlinks
https://github.com/torvalds/linux/commit/4c75431ac3520631f1d9e74aa88407e6374dbbc4

net: fix creation adjacent device symlinks
https://github.com/torvalds/linux/commit/7ce64c79c4decdeb1afe0bf2f6ef834b382871d1

These patches apply cleanly to 3.14.28. I think this should go into 3.14-stable.

For networking patches, can you cc: netdev and get an ack from the networking maintainer for me to be able to apply them?

thanks,

greg k-h

#2 lore raw
Quoted 2 lines · Greg KH

For networking patches, can you cc: netdev and get an ack from the networking maintainer for me to be able to apply them?

Done, and sorry for the [email protected] bounce.

Mike.