alsa-lib support for compress offload
Hi,
As far as I understand I need to use something similar to tinycompress to use alsa devices that supports compress offload. When I asked on gstreamer list [1] about alsasink support for compress offload they said yes. But I can see that gstalsasink.c [2] only uses the standard alsa-lib api which AFAICT doesn't support compress offload.
Did I misread the code and alsa-lib actually works with compress offload? Gstreamer refers to the feature "passthrough" and associate it with SPDIF[3], are they taking advantage of some other alsa feature that looks like compress offload?
Thanks,
Qais
[1] http://gstreamer-devel.966125.n4.nabble.com/ALSA-Compress-Offload-support-td4670153.html
[2] http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/alsa/gstalsasink.c#n836
[3] http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/alsa/gstalsa.c#n437
At Fri, 16 Jan 2015 09:52:58 +0000,
Quoted 9 lines · Qais Yousef
Hi,
As far as I understand I need to use something similar to tinycompress to use alsa devices that supports compress offload. When I asked on gstreamer list [1] about alsasink support for compress offload they said yes. But I can see that
gstalsasink.c[2] only uses the standard alsa-lib api which AFAICT doesn't support compress offload.
Quoted 4 lines
Did I misread the code and alsa-lib actually works with compress offload? Gstreamer refers to the feature "passthrough" and associate it with SPDIF[3], are they taking advantage of some other alsa feature that looks like compress offload?
It's a normal IEC958 passthrough, nothing to do with the compress offload. And, no, we have no support for compress API in alsa-lib yet. Just because no one submitted the patches.
Takashi
Quoted 14 lines · Takashi Iwai
At Fri, 16 Jan 2015 09:52:58 +0000,
Quoted 8 lines · Qais Yousef
Hi,
As far as I understand I need to use something similar to tinycompress to use alsa devices that supports compress offload. When I asked on gstreamer list [1] about alsasink support for compress offload they said yes. But I can see that
gstalsasink.c[2] only uses the standard alsa-lib api which AFAICT doesn't support compress offload.Quoted 4 lines
Did I misread the code and alsa-lib actually works with compress offload? Gstreamer refers to the feature "passthrough" and associate it with SPDIF[3], are they taking advantage of some other alsa feature that looks like compress offload?
Quoted 6 lines
It's a normal IEC958 passthrough, nothing to do with the compress offload. And, no, we have no support for compress API in alsa-lib yet. Just because no one submitted the patches.
Takashi
Thanks. I haven't used alsa-lib before but I might be able to send the patches if I get guidance of what needs doing. Is the expected API similar/same to what provided by tinycompress[1]?
Quoted 11 lines
Quoted 4 lines
It's a normal IEC958 passthrough, nothing to do with the compress offload. And, no, we have no support for compress API in alsa-lib yet. Just because no one submitted the patches.
Thanks. I haven't used alsa-lib before but I might be able to send the patches if I get guidance of what needs doing. Is the expected API similar/same to what provided by tinycompress[1]?
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones. -Pierre
Quoted 6 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
Well, it'd be nice to be able to support plugins for userspace output devices like networked audio sinks or for talking to an audio server to at least allow it to manage resource contention, or for providing soft decode for that matter. Currently the media frameworks do the job just fine so it's not really a big deal though.
Quoted 4 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones. -Pierre
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
Thanks,
Qais
Quoted 12 lines · Qais Yousef
Quoted 10 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-Pierre
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support? -Pierre
Quoted 15 lines · Pierre-Louis Bossart
Quoted 14 lines · Qais Yousef
Quoted 11 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-Pierre
Quoted 7 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support?
If the same API can be reused/extended, it'd mean allowing code reuse and not having to write entirely separate support for compressed devices in projects that use alsa-lib already. I don't know if that's actually feasible with the way the ALSA API works, though.
-- Arun
Quoted 13 lines · Pierre-Louis Bossart
Quoted 12 lines · Qais Yousef
Quoted 10 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-Pierre
Quoted 6 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support? -Pierre
Long story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
I am happy to use tinycompress if that's the official way alsa wants to support userland applications. When Takashi suggested that he didn't get patches for compress API support in alsa-lib I thought it was a hint it's a better idea to have it there. I think it makes sense to merge tinycompress into alsa-lib as this will make the functionality more readily available - if license is not an issue.
Quoted 28 lines · Qais Yousef
Quoted 13 lines · Pierre-Louis Bossart
Quoted 12 lines · Qais Yousef
Quoted 10 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-PierreQuoted 8 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support?
-PierreLong story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
Quoted 6 lines
I am happy to use tinycompress if that's the official way alsa wants to support userland applications. When Takashi suggested that he didn't get patches for compress API support in alsa-lib I thought it was a hint it's a better idea to have it there. I think it makes sense to merge tinycompress into alsa-lib as this will make the functionality more readily available - if license is not an issue.
Sorry for delayed reply, I am travelling.
tinycompress comes with dual license LGPL and BSD. Currently the main user of this is Android which picks up the BSD license.
Though I am not a lawyer, but I don't see a reason if alsa-lib uses LGPL license to take this lib and include compress support in alsa-lib. This way we have code reuse and take advantage of alsa-lib to support compress formats too. Takashi is that fine with you?
I would hate if we had to rewrite the simple wrappers over IOCTLs to support compress in alsa-lib!
Thanks
Signature · 1 line
~Vinod
Quoted 1 line · Vinod Koul
Sorry for delayed reply, I am travelling.
Thanks for taking the time to answer.
Quoted 9 lines
tinycompress comes with dual license LGPL and BSD. Currently the main user of this is Android which picks up the BSD license.
Though I am not a lawyer, but I don't see a reason if alsa-lib uses LGPL license to take this lib and include compress support in alsa-lib. This way we have code reuse and take advantage of alsa-lib to support compress formats too. Takashi is that fine with you?
Quoted 5 lines
I would hate if we had to rewrite the simple wrappers over IOCTLs to support compress in alsa-lib!
Thanks
Unless Takashi comes up with an objection, I'll work just on that.
Thanks,
Qais
At Tue, 20 Jan 2015 23:10:53 -0800,
Quoted 38 lines · Vinod Koul
Quoted 28 lines · Qais Yousef
Quoted 13 lines · Pierre-Louis Bossart
Quoted 12 lines · Qais Yousef
Quoted 10 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-PierreQuoted 8 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support?
-PierreLong story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
Quoted 6 lines
I am happy to use tinycompress if that's the official way alsa wants to support userland applications. When Takashi suggested that he didn't get patches for compress API support in alsa-lib I thought it was a hint it's a better idea to have it there. I think it makes sense to merge tinycompress into alsa-lib as this will make the functionality more readily available - if license is not an issue.
Sorry for delayed reply, I am travelling.
Quoted 7 lines
tinycompress comes with dual license LGPL and BSD. Currently the main user of this is Android which picks up the BSD license.
Though I am not a lawyer, but I don't see a reason if alsa-lib uses LGPL license to take this lib and include compress support in alsa-lib. This way we have code reuse and take advantage of alsa-lib to support compress formats too. Takashi is that fine with you?
Well, I see no big merit to merge into alsa-lib if API isn't compatible with others. At least the open function doesn't align with other functions taking the device name string.
Quoted 2 lines
I would hate if we had to rewrite the simple wrappers over IOCTLs to support compress in alsa-lib!
True.
The compress-offload support in alsa-lib is a "nice to have" one. But I guess the more interesting question right now is whether applications can use tinycompress as an "official" component. My (personal) answer is "yes". It doesn't conflict even if start implementing in alsa-lib, at least.
(BTW, from the packaging POV, tinycompress lacks a few proper things
in Makefile...)
thanks,
Takashi
Quoted 38 lines · Takashi Iwai
At Tue, 20 Jan 2015 23:10:53 -0800,
Quoted 36 lines · Vinod Koul
Quoted 24 lines · Qais Yousef
Quoted 11 lines · Pierre-Louis Bossart
Quoted 10 lines · Qais Yousef
Quoted 9 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-PierreQuoted 7 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support?
-PierreLong story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
Quoted 6 lines
I am happy to use tinycompress if that's the official way alsa wants to support userland applications. When Takashi suggested that he didn't get patches for compress API support in alsa-lib I thought it was a hint it's a better idea to have it there. I think it makes sense to merge tinycompress into alsa-lib as this will make the functionality more readily available - if license is not an issue.
Sorry for delayed reply, I am travelling.
tinycompress comes with dual license LGPL and BSD. Currently the main user of this is Android which picks up the BSD license.
Quoted 7 lines
Quoted 4 lines
Though I am not a lawyer, but I don't see a reason if alsa-lib uses LGPL license to take this lib and include compress support in alsa-lib. This way we have code reuse and take advantage of alsa-lib to support compress formats too. Takashi is that fine with you?
Well, I see no big merit to merge into alsa-lib if API isn't compatible with others. At least the open function doesn't align with other functions taking the device name string.
IMHO for a newcomer to alsa like me I expect to find all alsa features supported by the kernel supported in alsa-lib too. It's confusing when I need to use different libraries for different alsa features. Especially in this case I don't see the necessity for a different package - except you need non LGPL license. I *think* having the API in alsa-lib will ensure the documentation is consistent and can be found in one place.
Quoted 18 lines
Quoted 3 lines
I would hate if we had to rewrite the simple wrappers over IOCTLs to support compress in alsa-lib!
True.
The compress-offload support in alsa-lib is a "nice to have" one. But I guess the more interesting question right now is whether applications can use tinycompress as an "official" component. My (personal) answer is "yes". It doesn't conflict even if start implementing in alsa-lib, at least.
(BTW, from the packaging POV, tinycompress lacks a few proper things
inMakefile...)thanks,
Takashi
Quoted 5 lines
Long story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
The problem when you use a gstreamer->tinycompress path is that you have no hooks for volume control and audio policy/routing. It'll remain a test toy. If you want integration with a better user-friendly support, the right answer is to go through PulseAudio and write a compressed sink within pulseaudio. See the LPC slides from 2010 or 2011 that describe the solution. And Arun can help you with that, he wrote the gstreamer/pulseaudio interface :-)
Quoted 43 lines · Takashi Iwai
At Tue, 20 Jan 2015 23:10:53 -0800,
Quoted 41 lines · Vinod Koul
Quoted 28 lines · Qais Yousef
Quoted 13 lines · Pierre-Louis Bossart
Quoted 12 lines · Qais Yousef
Quoted 10 lines · Pierre-Louis Bossart
Since there is no allowed processing/reformatting/reshuffling of compressed data, all the plugin system needs to be bypassed and you'd be looking at an alsa-lib API that interfaces directly with the ioctls, essentially replicating what tinycompress does. I agree it's not great to have independent packages, the decision to maintain tinycompress separately was driven by licensing concerns, not technical ones.
-PierreQuoted 8 lines
Quoted 2 lines
I'm not sure how dual licensing work. Is it ok to base alsa-lib support for compress API on tinycompress then?
no idea, and what is the objective really? it's not clear what you are trying to achieve and what would be the merits of enhancing alsa-lib with compressed audio support?
-PierreLong story short, I am writing a new ALSA driver that supports compress offload. The only user land support I could find is in tinycompress. I was looking at adding gstreamer support to facilitate my testing and hopefully make the driver more useful.
Quoted 6 lines
I am happy to use tinycompress if that's the official way alsa wants to support userland applications. When Takashi suggested that he didn't get patches for compress API support in alsa-lib I thought it was a hint it's a better idea to have it there. I think it makes sense to merge tinycompress into alsa-lib as this will make the functionality more readily available - if license is not an issue.
Sorry for delayed reply, I am travelling.
tinycompress comes with dual license LGPL and BSD. Currently the main user of this is Android which picks up the BSD license.
Quoted 8 lines
Quoted 4 lines
Though I am not a lawyer, but I don't see a reason if alsa-lib uses LGPL license to take this lib and include compress support in alsa-lib. This way we have code reuse and take advantage of alsa-lib to support compress formats too. Takashi is that fine with you?
Well, I see no big merit to merge into alsa-lib if API isn't compatible with others. At least the open function doesn't align with other functions taking the device name string.
Can we actually support compress with current alsa APIs? If yes then we can do rework and keep current tinycompress APIs for Andporid and let core lib be reused, if not then we can go with these new APIs
Quoted 5 lines
Quoted 2 lines
I would hate if we had to rewrite the simple wrappers over IOCTLs to support compress in alsa-lib!
True.
Quoted 8 lines
The compress-offload support in alsa-lib is a "nice to have" one. But I guess the more interesting question right now is whether applications can use tinycompress as an "official" component. My (personal) answer is "yes". It doesn't conflict even if start implementing in alsa-lib, at least.
(BTW, from the packaging POV, tinycompress lacks a few proper things
inMakefile...)
The Makefiles were added just to check sanity and do quick compilation. Patches to fix this are welcome :)
Signature · 1 line
~Vinod
Quoted 3 lines · Vinod Koul
Can we actually support compress with current alsa APIs? If yes then we can do rework and keep current tinycompress APIs for Andporid and let core lib be reused, if not then we can go with these new APIs
No. We need to be able to pass decoder/encoder parameters, and we need the ability to deal with bytes, without any fixed mapping between bytes and time. If we want any convergence we'd need ALSA to deal with bytes only and not frames, in addition to the extra configuration steps, which would be a complete API change. -Pierre
At Thu, 22 Jan 2015 16:03:16 -0600,
Quoted 11 lines · Pierre-Louis Bossart
Quoted 3 lines · Vinod Koul
Can we actually support compress with current alsa APIs? If yes then we can do rework and keep current tinycompress APIs for Andporid and let core lib be reused, if not then we can go with these new APIs
No. We need to be able to pass decoder/encoder parameters, and we need the ability to deal with bytes, without any fixed mapping between bytes and time. If we want any convergence we'd need ALSA to deal with bytes only and not frames, in addition to the extra configuration steps, which would be a complete API change.
I don't think of merging the compress offload into PCM alsa-lib API. My point is only that the API function forms in tinycompress should be aligned with the existing alsa-lib API functions, e.g. open should take the name string, etc. Managing the compress offload into the PCM API would need redesigns, and I don't think it's worth.
Takashi