ath3k: Add support of AR3012 bluetooth 13d3:3423 device

PATCH In review Dmitry Tunin 2 participants 9 messages Jan 16, 2015 – Jan 18, 2015

Subsystems (2)

Stable branch Bluetooth drivers

lore

Share & tools

lore

Dmitry Tunin

author

2015-01-16 21:45 UTC #0 lore raw

PATCH 1/1 ath3k: Add support of AR3012 bluetooth 13d3:3423 device

Add support of 13d3:3423 device.

BugLink https://bugs.launchpad.net/bugs/1411193

---

T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3423 Rev= 0.01
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01 I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms

Signed-off-by Dmitry Tunin <[email protected]>

Cc [email protected]

---
 drivers/bluetooth/ath3k.c | 2 ++
 drivers/bluetooth/btusb.c | 1 +
 2 files changed, 3 insertions(+)

drivers/bluetooth/ath3k.c +2 -0

index 1ee27ac..13a64d0 100644
@@ -108,6 +108,7 @@ static const struct usb_device_id ath3k_table[] = {
 	{ USB_DEVICE(0x13d3, 0x3393) },
 	{ USB_DEVICE(0x13d3, 0x3402) },
 	{ USB_DEVICE(0x13d3, 0x3408) },
+	{ USB_DEVICE(0x13d3, 0x3423) },
 	{ USB_DEVICE(0x13d3, 0x3432) },
 
 	/* Atheros AR5BBU12 with sflash firmware */

@@ -162,6 +163,7 @@ static const struct usb_device_id ath3k_blist_tbl[] = {
 	{ USB_DEVICE(0x13d3, 0x3393), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3408), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3423), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3432), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU22 with sflash firmware */

drivers/bluetooth/btusb.c +1 -0

index 4a6495a..1211c74 100644
@@ -189,6 +189,7 @@ static const struct usb_device_id blacklist_table[] = {
 	{ USB_DEVICE(0x13d3, 0x3393), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3408), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3423), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x13d3, 0x3432), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU12 with sflash firmware */

Signature · 1 line

1.9.1

Marcel Holtmann

maintainer

2015-01-17 04:32 UTC #1 lore raw

Hi Dmitry,

Quoted 34 lines

Add support of 13d3:3423 device.
BugLink https://bugs.launchpad.net/bugs/1411193
---
T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3423 Rev= 0.01
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01 I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms

Quoted 6 lines

Signed-off-by Dmitry Tunin <[email protected]>
Cc [email protected]
---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +
2 files changed, 3 insertions(+)

your patch does not apply cleanly:

Applying: ath3k: Add support of AR3012 bluetooth 13d3:3423 device
error: patch failed: drivers/bluetooth/ath3k.c:108
error: drivers/bluetooth/ath3k.c: patch does not apply
error: patch failed: drivers/bluetooth/btusb.c:189
error: drivers/bluetooth/btusb.c: patch does not apply
Patch failed at 0001 ath3k: Add support of AR3012 bluetooth 13d3:3423 device

Please send patches that can be applied against bluetooth-next tree.

Regards

Marcel

Dmitry Tunin

author

2015-01-17 08:26 UTC #2 lore raw

Hi Marcel,

This patch is against git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
Or is it another branch?

I pulled it again, but still no changes. Why it can be?

17.01.2015 07:32, Marcel Holtmann пишет:

Quoted 58 lines

Hi Dmitry,
Quoted 34 lines
Add support of 13d3:3423 device.
BugLink https://bugs.launchpad.net/bugs/1411193
---
T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3423 Rev= 0.01
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01 I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
Quoted 6 lines
Signed-off-by Dmitry Tunin <[email protected]>
Cc [email protected]
---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +
2 files changed, 3 insertions(+)
your patch does not apply cleanly:
Applying: ath3k: Add support of AR3012 bluetooth 13d3:3423 device
error: patch failed: drivers/bluetooth/ath3k.c:108
error: drivers/bluetooth/ath3k.c: patch does not apply
error: patch failed: drivers/bluetooth/btusb.c:189
error: drivers/bluetooth/btusb.c: patch does not apply
Patch failed at 0001 ath3k: Add support of AR3012 bluetooth 13d3:3423 device
Please send patches that can be applied against bluetooth-next tree.
Regards
Marcel

Marcel Holtmann

maintainer

2015-01-17 18:59 UTC #3 lore raw

Hi Dmitry,

please do not top post on this mailing list.

Quoted 4 lines

This patch is against git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
Or is it another branch?
I pulled it again, but still no changes. Why it can be?

it neither applies with git am, nor manually running patch.

checking file drivers/bluetooth/ath3k.c
Hunk #1 FAILED at 108.
Hunk #2 FAILED at 162.
2 out of 2 hunks FAILED
checking file drivers/bluetooth/btusb.c
Hunk #1 FAILED at 189.
1 out of 1 hunk FAILED

Regards

Marcel

Dmitry Tunin

author

2015-01-17 19:57 UTC #4 lore raw

Any ideas what may be wrong? Is the tree URL correct or there is another bluetooth-next branch I dot know about? I just clean cloned it again and applied with no problem.

17.01.2015 21:59, Marcel Holtmann пишет:

Quoted 23 lines

Hi Dmitry,
please do not top post on this mailing list.
Quoted 4 lines
This patch is against git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
Or is it another branch?
I pulled it again, but still no changes. Why it can be?
it neither applies with git am, nor manually running patch.
checking file drivers/bluetooth/ath3k.c
Hunk #1 FAILED at 108.
Hunk #2 FAILED at 162.
2 out of 2 hunks FAILED
checking file drivers/bluetooth/btusb.c
Hunk #1 FAILED at 189.
1 out of 1 hunk FAILED
Regards
Marcel

Marcel Holtmann

maintainer

2015-01-17 20:05 UTC #5 lore raw

Hi Dmitry,

Quoted 2 lines

Any ideas what may be wrong? Is the tree URL correct or there is another bluetooth-next branch I dot know about? I just clean cloned it again and applied with no problem.

I did ask nicely to not top post on this mailing list. Please respect our netiquette.

Save the original email as it arrives on the mailing list and try by yourself. I tried twice now and it just does not apply. It could be well that your email client messed it up somewhere along the lines. Maybe Johan has more luck, but on my tree it does not apply.

Regards

Marcel

Dmitry Tunin

author

2015-01-17 16:40 UTC #6 lore raw

In reply to Marcel Holtmann

Marcel,

This patch ckeanly applies both to bluetooth-next and mainline linux tree.

17.01.2015 07:32, Marcel Holtmann пишет:

Quoted 58 lines

Hi Dmitry,
Quoted 34 lines
Add support of 13d3:3423 device.
BugLink https://bugs.launchpad.net/bugs/1411193
---
T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3423 Rev= 0.01
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01 I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
Quoted 6 lines
Signed-off-by Dmitry Tunin <[email protected]>
Cc [email protected]
---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +
2 files changed, 3 insertions(+)
your patch does not apply cleanly:
Applying: ath3k: Add support of AR3012 bluetooth 13d3:3423 device
error: patch failed: drivers/bluetooth/ath3k.c:108
error: drivers/bluetooth/ath3k.c: patch does not apply
error: patch failed: drivers/bluetooth/btusb.c:189
error: drivers/bluetooth/btusb.c: patch does not apply
Patch failed at 0001 ath3k: Add support of AR3012 bluetooth 13d3:3423 device
Please send patches that can be applied against bluetooth-next tree.
Regards
Marcel

Dmitry Tunin

author

2015-01-17 21:01 UTC #7 lore raw

You are correct. It does not apply after it goes thru email. But I tried to send it using git send-email to myself with same result. This is mystics.

Dmitry Tunin

author

2015-01-18 10:57 UTC #8 lore raw

The Thunderbird client after update to 31.3.0 adds extra Space symbols at some lines for some reason. Before the update it was OK, when properly set up not to wrap lines.

In my initial patch at 234 is an extra Space before Tab.

I will use git for good now.