Skip to contentSkip to conversation

Missing include for out of tree build

lttng-tools 2.5 Jérémie Galarneau 1 participant 1 message Jun 25, 2015 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Necro-bumping this to confirm this was merged as in stable-2.5 on Fri Feb 6 15:42:07 2015 -0500.

Thanks!
Jérémie

Quoted 41 lines · Jonathan Rajotte Julien

Hey,

While making sure we support out of tree build for lttng-tools master/stable-2.6/stable-2.5 I found that 2.5 was failing at oot build. After some digging, it looks like a patch submitted to fix this problem was not backported to 2.5.

The commit in question currently in master and 2.6 branch :

commit 4900d3cd9c4accc131a6a79986151cf3e6236031

Author: Mathieu Desnoyers <[email protected]>
Date:   Tue Jul 29 18:10:27 2014 -0400

Fix: out of tree build by adding missing ini.c include

src/common/config/ini.c +2 -0
index 4369a32..7b2a4b6 100644
@@ -31,9 +31,11 @@
  * http://code.google.com/p/inih/
  */
 
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <ctype.h>
 #include <string.h>
+#include <common/common.h>
 
 #include "ini.h"
 

Cheers!

--
Jonathan R. Julien
Efficios

Signature · 3 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev