Skip to contentSkip to conversation

Small code issue

DISCUSSION hujianyang 2 participants 2 messages Feb 2, 2015 – Mar 5, 2015

lore
Share & tools
lore

hujianyang

author
#0 lore raw

Hi Miklos,

I was backporting overlayfs for linux 3.16 last week and found a small issue in the patch:

commit c771d683: vfs: introduce clone_private_mount()

this patch adds *struct path* to include/linux/mount.h, but actually *struct path* is already added to this file by

commit 3064c356: death to mnt_pinned

It's bother to send a patch for fixing an issue like this, so if you've got other same problems, you could merge them with this together.

Thanks,
Hu

#1 lore raw
Quoted 11 lines · hujianyang

Hi Miklos,

I was backporting overlayfs for linux 3.16 last week and found a small issue in the patch:

commit c771d683: vfs: introduce clone_private_mount()

this patch adds *struct path* to include/linux/mount.h, but actually *struct path* is already added to this file by

Quoted 6 lines

commit 3064c356: death to mnt_pinned

It's bother to send a patch for fixing an issue like this, so if you've got other same problems, you could merge them with this together.

Lets just create a separate patch.

Thanks,
Miklos