Skip to contentSkip to conversation

stmmac: pci: add MSI support for Intel Quark X1000

PATCH Bryan O'Donoghue 3 participants 4 messages Feb 2, 2015 – Feb 4, 2015

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
Quoted 7 lines · Bryan O'Donoghue

Hi guys.

Has the issue with PVM masking been addressed ?

https://lkml.org/lkml/2014/10/1/221

If not then please drop MSIs from this patchset.

I do not see the reason why it should be done on per driver basis. Care to fix this under arch/x86 then when adding new Quark platform?

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#2 lore raw
Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Bryan O'Donoghue

Hi guys.

Has the issue with PVM masking been addressed ?

https://lkml.org/lkml/2014/10/1/221

If not then please drop MSIs from this patchset.

I do not see the reason why it should be done on per driver basis.

Agree.

Quoted 1 line

Care to fix this under arch/x86 then when adding new Quark platform?

Looking into that now.

Hmm - OK -let's aim to get a fix in for the bridge and leave the MSI enable in place.

#3 lore raw
Quoted 21 lines

-----Original Message-----
From: Bryan O'Donoghue [mailto:[email protected]]
Sent: Monday, February 02, 2015 11:50 PM
To: Andy Shevchenko
Cc: [email protected]; Kweh, Hock Leong; [email protected]; Ahmad, Josef
Subject: Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Bryan O'Donoghue

Hi guys.

Has the issue with PVM masking been addressed ?

https://lkml.org/lkml/2014/10/1/221

If not then please drop MSIs from this patchset.

I do not see the reason why it should be done on per driver basis.

Quoted 9 lines

Agree.

Quoted 1 line

Care to fix this under arch/x86 then when adding new Quark platform?

Looking into that now.

Hmm - OK -let's aim to get a fix in for the bridge and leave the MSI enable in place.

I am also agreeing on that. Thanks.

Regards,
Wilson