Skip to contentSkip to conversation

iio/magnetometer: fix AK09911 dependencies

PATCH In review Randy Dunlap 2 participants 2 messages Feb 4, 2015 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio/magnetometer: fix AK09911 dependencies

From: Randy Dunlap <[email protected]>

Fix AK09911 dependencies to eliminate these build errors (since 'select' does not follow dependencies):

drivers/built-in.o: In function `ak8975_set_mode':
X32/../drivers/iio/magnetometer/ak8975.c:431: undefined reference to i2c_smbus_write_byte_data' drivers/built-in.o: In function ak8975_read_raw':
X32/../drivers/iio/magnetometer/ak8975.c:572: undefined reference to i2c_smbus_read_byte_data' X32/../drivers/iio/magnetometer/ak8975.c:555: undefined reference to i2c_smbus_read_byte_data' X32/../drivers/iio/magnetometer/ak8975.c:650: undefined reference to i2c_smbus_read_word_data' X32/../drivers/iio/magnetometer/ak8975.c:634: undefined reference to i2c_smbus_read_byte_data' drivers/built-in.o: In function `ak8975_probe':
X32/../drivers/iio/magnetometer/ak8975.c:393: undefined reference to i2c_smbus_read_i2c_block_data' X32/../drivers/iio/magnetometer/ak8975.c:506: undefined reference to i2c_smbus_read_i2c_block_data' drivers/built-in.o: In function `ak8975_driver_init':
X32/../drivers/iio/magnetometer/ak8975.c:846: undefined reference to i2c_register_driver' drivers/built-in.o: In function ak8975_driver_exit':
X32/../drivers/iio/magnetometer/ak8975.c:846: undefined reference to i2c_del_driver' drivers/built-in.o:(.debug_addr+0x4d868): undefined reference to i2c_register_driver' drivers/built-in.o:(.debug_addr+0x4d89c): undefined reference to i2c_smbus_write_byte_data' drivers/built-in.o:(.debug_addr+0x4d8a4): undefined reference to i2c_smbus_read_word_data' drivers/built-in.o:(.debug_addr+0x4d98c): undefined reference to i2c_del_driver' drivers/built-in.o:(.debug_addr+0x4da14): undefined reference to i2c_smbus_read_i2c_block_data' drivers/built-in.o:(.debug_addr+0x4dad4): undefined reference to `i2c_smbus_read_byte_data'

Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald <[email protected]>
---
 drivers/iio/magnetometer/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/iio/magnetometer/Kconfig +1 -0
@@ -18,6 +18,7 @@ config AK8975
 
 config AK09911
 	tristate "Asahi Kasei AK09911 3-axis Compass"
+	depends on I2C && GPIOLIB
 	select AK8975
 	help
 	  Deprecated: AK09911 is now supported by AK8975 driver.
maintainer
#1 lore raw
Quoted 26 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix AK09911 dependencies to eliminate these build errors (since 'select' does not follow dependencies):

drivers/built-in.o: In function `ak8975_set_mode':
X32/../drivers/iio/magnetometer/ak8975.c:431: undefined reference to i2c_smbus_write_byte_data' drivers/built-in.o: In function ak8975_read_raw':
X32/../drivers/iio/magnetometer/ak8975.c:572: undefined reference to i2c_smbus_read_byte_data' X32/../drivers/iio/magnetometer/ak8975.c:555: undefined reference to i2c_smbus_read_byte_data' X32/../drivers/iio/magnetometer/ak8975.c:650: undefined reference to i2c_smbus_read_word_data' X32/../drivers/iio/magnetometer/ak8975.c:634: undefined reference to i2c_smbus_read_byte_data' drivers/built-in.o: In function `ak8975_probe':
X32/../drivers/iio/magnetometer/ak8975.c:393: undefined reference to i2c_smbus_read_i2c_block_data' X32/../drivers/iio/magnetometer/ak8975.c:506: undefined reference to i2c_smbus_read_i2c_block_data' drivers/built-in.o: In function `ak8975_driver_init':
X32/../drivers/iio/magnetometer/ak8975.c:846: undefined reference to i2c_register_driver' drivers/built-in.o: In function ak8975_driver_exit':
X32/../drivers/iio/magnetometer/ak8975.c:846: undefined reference to i2c_del_driver' drivers/built-in.o:(.debug_addr+0x4d868): undefined reference to i2c_register_driver' drivers/built-in.o:(.debug_addr+0x4d89c): undefined reference to i2c_smbus_write_byte_data' drivers/built-in.o:(.debug_addr+0x4d8a4): undefined reference to i2c_smbus_read_word_data' drivers/built-in.o:(.debug_addr+0x4d98c): undefined reference to i2c_del_driver' drivers/built-in.o:(.debug_addr+0x4da14): undefined reference to i2c_smbus_read_i2c_block_data' drivers/built-in.o:(.debug_addr+0x4dad4): undefined reference to `i2c_smbus_read_byte_data'

Quoted 7 lines
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald <[email protected]>

---

Hi Randy,

Thanks, Arnd Bergman got their first. Unfortunately I failed to apply before sending the pull request on to Greg. Will follow this up asap... (which might not be that quick as I'm travelling until the weekend).

Jonathan

Quoted 14 lines
 drivers/iio/magnetometer/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/iio/magnetometer/Kconfig +1 -0
@@ -18,6 +18,7 @@ config AK8975
 
 config AK09911
 	tristate "Asahi Kasei AK09911 3-axis Compass"
+	depends on I2C && GPIOLIB
 	select AK8975
 	help
 	  Deprecated: AK09911 is now supported by AK8975 driver.