Skip to contentSkip to conversation

arm: kprobe compilation error

DISCUSSION Janusz Użycki 4 participants 6 messages Feb 5, 2015 – Feb 10, 2015

lore
Share & tools
lore
#0 lore raw

Hi,

I got the compilation error on next-20150204:

CC arch/arm/probes/kprobes/actions-arm.o
In file included from arch/arm/probes/kprobes/actions-common.c:18:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/actions-common.o] B??d 1 make[2]: *** Oczekiwanie na niezako?czone zadania....
In file included from arch/arm/probes/kprobes/actions-arm.c:66:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/actions-arm.o] B??d 1 In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/core.o] B??d 1 make[1]: *** [arch/arm/probes/kprobes] B??d 2
make: *** [arch/arm/probes] B??d 2

reason is *[*]:

const struct decode_checker *[*]);
                                                      ^

target: mxs (arm926)
gcc version 4.2.4

best regards
Janusz

#1 lore raw
Quoted 21 lines · Janusz U?ycki

Hi,

I got the compilation error on next-20150204:

CC arch/arm/probes/kprobes/actions-arm.o
In file included from arch/arm/probes/kprobes/actions-common.c:18:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/actions-common.o] B??d 1 make[2]: *** Oczekiwanie na niezako?czone zadania....
In file included from arch/arm/probes/kprobes/actions-arm.c:66:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/actions-arm.o] B??d 1 In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration
make[2]: *** [arch/arm/probes/kprobes/core.o] B??d 1 make[1]: *** [arch/arm/probes/kprobes] B??d 2
make: *** [arch/arm/probes] B??d 2

Quoted 2 lines

reason is *[*]:
const struct decode_checker *[*]);

Thank you for reporting!

I think there is a typo, it should be "const struct decode_checker *[]".

Thank you,

Signature · 4 lines
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt at hitachi.com
#2 lore raw
In reply to Janusz Użycki

Hi Janusz

Quoted 2 lines · Janusz U?ycki

I got the compilation error on next-20150204:

[...]

Quoted 3 lines

In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration

[...]

Quoted 1 line

gcc version 4.2.4

Thanks for reporting this, is it OK if I add to a patch to fix this a line saying "Reported-by: Janusz U?ycki <[email protected]>"?

Whilst the extra '*' looks like an obvious typo, it's interesting that your error message implies that it's allowed in some situations and that the version of GCC that I use (4.9.1) doesn't complain about it. If it's valid C, I've no idea what that syntax that might represent.

Signature · 1 line
Tixy 
#3 lore raw

W dniu 2015-02-09 o 10:44, Jon Medhurst (Tixy) pisze:

Quoted 5 lines

Hi Janusz

Quoted 2 lines · Janusz Użycki

I got the compilation error on next-20150204:

Quoted 8 lines

[...]

Quoted 3 lines

In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration

[...]

Quoted 1 line

gcc version 4.2.4

Thanks for reporting this, is it OK if I add to a patch to fix this a line saying "Reported-by: Janusz Użycki <[email protected]>"?

sure

Quoted 6 lines

Whilst the extra '*' looks like an obvious typo, it's interesting that your error message implies that it's allowed in some situations and that the version of GCC that I use (4.9.1) doesn't complain about it. If it's valid C, I've no idea what that syntax that might represent.

I've not find such extension in C11 but likely gcc's team knows the answer. It also compiles using gcc 4.8.3. However I thing more people use older compilers for different platforms.

best regards
Janusz

#4 lore raw
Quoted 19 lines · Janusz U?ycki

W dniu 2015-02-09 o 10:44, Jon Medhurst (Tixy) pisze:

Quoted 5 lines

Hi Janusz

Quoted 2 lines · Janusz U?ycki

I got the compilation error on next-20150204:

Quoted 8 lines

[...]

Quoted 3 lines

In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration

[...]

Quoted 1 line

gcc version 4.2.4

Thanks for reporting this, is it OK if I add to a patch to fix this a line saying "Reported-by: Janusz U?ycki <[email protected]>"?

sure

Quoted 1 line
Quoted 9 lines
Quoted 5 lines

Whilst the extra '*' looks like an obvious typo, it's interesting that your error message implies that it's allowed in some situations and that the version of GCC that I use (4.9.1) doesn't complain about it. If it's valid C, I've no idea what that syntax that might represent.

I've not find such extension in C11 but likely gcc's team knows the answer. It also compiles using gcc 4.8.3. However I thing more people use older compilers for different platforms.

Hi All,

Thanks for reporting and fixing this.

When writing this code I checked C spec from open-std (n1548 and n1570). I got an feeling that [*] should be a standard way to specify variable length array types. Please see 6.7.6.3 and 6.7.7 of the spec. However I forgot there are old gccs which don't support that standard.

Thank you!

Quoted 3 lines

best regards
Janusz

#5 lore raw
Quoted 32 lines · Wang Nan
Quoted 19 lines · Janusz U?ycki

W dniu 2015-02-09 o 10:44, Jon Medhurst (Tixy) pisze:

Quoted 5 lines

Hi Janusz

Quoted 2 lines · Janusz U?ycki

I got the compilation error on next-20150204:

Quoted 8 lines

[...]

Quoted 3 lines

In file included from arch/arm/probes/kprobes/core.c:37:
arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration

[...]

Quoted 1 line

gcc version 4.2.4

Thanks for reporting this, is it OK if I add to a patch to fix this a line saying "Reported-by: Janusz U?ycki <[email protected]>"?

sure

Quoted 1 line
Quoted 9 lines
Quoted 5 lines

Whilst the extra '*' looks like an obvious typo, it's interesting that your error message implies that it's allowed in some situations and that the version of GCC that I use (4.9.1) doesn't complain about it. If it's valid C, I've no idea what that syntax that might represent.

I've not find such extension in C11 but likely gcc's team knows the answer. It also compiles using gcc 4.8.3. However I thing more people use older compilers for different platforms.

Hi All,

Quoted 9 lines

Thanks for reporting and fixing this.

When writing this code I checked C spec from open-std (n1548 and n1570). I got an feeling that [*] should be a standard way to specify variable length array types. Please see 6.7.6.3 and 6.7.7 of the spec. However I forgot there are old gccs which don't support that standard.

Thank you!

I did a boring searching and found some useful information:

The '[*]' syntax was introduced at 1997 as part of variable length array (VLA) support:

http://www.open-std.org/JTC1/SC22/WG14/www/docs/n683.htm

so it is not a new extension. However, according to 6.7.6.2 of the spec:

If the size is not present, the array type is an incomplete type. If the size is * instead of being an expression, the array type is a variable length array type of unspecified size,
...
(Variable length arrays are a conditional feature that implementations need not support; see 6.10.8.3.)

and 6.10.8.3 provides a macro:

__STDC_NO_VLA__ The integer constant 1, intended to indicate that the
implementation does not support variable length arrays or variably modified types.

In our situation what we need is an incomplete type of array, so Tixy's fix is correct. It's my fault to incorrectly use VLA.

Thank you.

Quoted 11 lines
Quoted 3 lines

best regards
Janusz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel