epoll: Add implementation for epoll_ctl_batch
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (ncmds <= 0 || !cmds) + return -EINVAL; + cmd_size = sizeof(struct epoll_ctl_cmd) * ncmds; + kcmds = kmalloc(cmd_size, GFP_KERNEL);
You should probably fix the integer overflow in the calculation of the cmd_size variable, unless you like root vulnerabilities.
Quoted 8 lines · Dan Rosenberg
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (ncmds <= 0 || !cmds) + return -EINVAL; + cmd_size = sizeof(struct epoll_ctl_cmd) * ncmds; + kcmds = kmalloc(cmd_size, GFP_KERNEL);You should probably fix the integer overflow in the calculation of the
cmd_sizevariable, unless you like root vulnerabilities.
Thanks! In the case of multiply overflow, we allocate a buffer that is smaller than we think, and consequent writings will corrupt kernel memory after it. That is the root vulnerabilities here. Will fix!
Fam