ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D

PATCH In review Jens Reyer 3 participants 4 messages Feb 14, 2015 – Feb 18, 2015 ACPI

Share & tools

Jens Reyer

author

2015-02-14 23:20 UTC #0 lore raw

PATCH 1/1 ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D

The native intel backlight controls do not work correctly on SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D laptops as I reported in
https://bugs.freedesktop.org/show_bug.cgi?id=87286 (and
https://bugs.debian.org/772440).

Aaron Lu told me there to speak up here/to Rafael.

Please find attached a patch to disable the native backlight on this laptop model, like it was already done for some other older models.

I assume this would be the proper commit comments (or should it be signed-off?):
Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286.

Reported-and-tested-by Jens Reyer <[email protected]>

The patch applies to
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
branch linux-next, head at
389a8d43d64711b0e7282d227e05a6a71b43753d
Rafael J. Wysocki 2015-02-12 22:43:26

I verified the issues are still present in linux-next and get solved with this patch.

Just tell me if there is anything else I can do to get this applied.

Thanks
Jens Reyer/jre <[email protected]>

drivers/acpi/video.c +9 -0

index 88a4f99..debd309 100644
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

Aaron Lu

2015-02-16 05:26 UTC #1 lore raw

Quoted 9 lines · Jens Reyer

Hi
The native intel backlight controls do not work correctly on SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D laptops as I reported in
https://bugs.freedesktop.org/show_bug.cgi?id=87286 (and
https://bugs.debian.org/772440).
Aaron Lu told me there to speak up here/to Rafael.

Quoted 7 lines

Please find attached a patch to disable the native backlight on this laptop model, like it was already done for some other older models.
I assume this would be the proper commit comments (or should it be signed-off?):
Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286.
Reported-and-tested-by Jens Reyer <[email protected]>

You will need to add the Signed-off-by: line to get the patch merged.

Thanks,
Aaron

Quoted 35 lines

The patch applies to
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
branch linux-next, head at
389a8d43d64711b0e7282d227e05a6a71b43753d
Rafael J. Wysocki 2015-02-12 22:43:26
I verified the issues are still present in linux-next and get solved with this patch.
Just tell me if there is anything else I can do to get this applied.
Thanks
Jens Reyer/jre <[email protected]>
drivers/acpi/video.c +9 -0
index 88a4f99..debd309 100644
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

Jens Reyer

author

2015-02-17 18:08 UTC #2 lore raw

PATCH v2 1/1 ACPI / video: Disable native backlight on Samsung Series 9 laptops

Add video_disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/ 900X3E/900X4C/900X4D laptops.

The native intel backlight controls do not work correctly on SAMSUNG Series 9 (900X3C/900X3D/900X3E/900X4C/900X4D) laptops:
One machine has an completely dimmed (= black) display after boot at the GDM login screen and brightness controls work only between 0 and 5% (= no effect).
Another machine has the same brightness control issues if an external HDMI monitor is or gets connected, although the initial brightness is ok.
After login to Gnome both machines always work fine.

Tested on both machines.

Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286
Bug-Link: https://bugs.debian.org/772440

Signed-off-by Jens Reyer <[email protected]>

---
 drivers/acpi/video.c | 9 +++++++++
 1 file changed, 9 insertions(+)

drivers/acpi/video.c +9 -0

index 88a4f99..debd309 100644
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

Signature · 1 line

2.1.4

Rafael J. Wysocki

Applied

2015-02-18 05:54 UTC #3 lore raw

Re: [PATCH v2] ACPI / video: Disable native backlight on Samsung Series 9 laptops

Quoted 13 lines · Jens Reyer

Add video_disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/ 900X3E/900X4C/900X4D laptops.
The native intel backlight controls do not work correctly on SAMSUNG Series 9 (900X3C/900X3D/900X3E/900X4C/900X4D) laptops:
One machine has an completely dimmed (= black) display after boot at the GDM login screen and brightness controls work only between 0 and 5% (= no effect).
Another machine has the same brightness control issues if an external HDMI monitor is or gets connected, although the initial brightness is ok.
After login to Gnome both machines always work fine.

Quoted 5 lines

Tested on both machines.
Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286
Bug-Link: https://bugs.debian.org/772440
Signed-off-by Jens Reyer <[email protected]>

Applied, thanks!

Quoted 25 lines

---
 drivers/acpi/video.c | 9 +++++++++
 1 file changed, 9 insertions(+)

drivers/acpi/video.c +9 -0

index 88a4f99..debd309 100644
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

Signature · 2 lines

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.