Skip to contentSkip to conversation

Any idea why we cannot disable /b rates?

DISCUSSION Ben Greear 2 participants 7 messages Feb 24, 2015 – Mar 10, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

I'm going to start digging into the code, but in case someone already knows...

I ran this command to try to disable any frames set at /b rates (AP is on channel 1).

But, according to ath10k sniffer, beacons are still sent with 1Mbps rate.

iw dev vap1 set bitrates legacy-2.4 12 mcs-2.4

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#1 lore raw

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Thanks,
Ben

Quoted 13 lines · Ben Greear

I'm going to start digging into the code, but in case someone already knows...

I ran this command to try to disable any frames set at /b rates (AP is on channel 1).

But, according to ath10k sniffer, beacons are still sent with 1Mbps rate.

iw dev vap1 set bitrates legacy-2.4 12 mcs-2.4

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
Quoted 8 lines · Ben Greear

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps).

So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate.

---
Chun-Yeow

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

author
#3 lore raw
Quoted 10 lines · Yeoh Chun-Yeow
Quoted 8 lines · Ben Greear

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Quoted 7 lines

Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps).

So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate.

User-space API doesn't give the ability to set different fixed rates for different packet types, as far as I know.

So, the current firmware just ignores the fixed rate for management and broadcast frames.

My firmware change makes the fixed rate apply equally to all types of frames.

Should I make my change optional for mgt/bcast , or should it always set mgt/bcast rates to the same fixed rates as data packets use?

Thanks,
Ben

Quoted 4 lines

---
Chun-Yeow

Signature · 7 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#4 lore raw
Quoted 34 lines · Ben Greear
Quoted 15 lines · Yeoh Chun-Yeow
Quoted 10 lines · Ben Greear

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another
for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Quoted 7 lines

Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps).

So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate.

User-space API doesn't give the ability to set different fixed rates for different packet types, as far as I know.

So, the current firmware just ignores the fixed rate for management and broadcast
frames.

Quoted 6 lines

My firmware change makes the fixed rate apply equally to all types of frames.

Should I make my change optional for mgt/bcast , or should it always set mgt/bcast rates to the
same fixed rates as data packets use?

In iw, we have the following:
dev <devname> set mcast_rate <rate in Mbps>
dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] [mcs-<2.4|5> <MCS index>*]

mcast-rate should be something set for broadcast/multicast frame including the management and data frame. This allows us to have in example beacon frame to be transmitted with higher rate from 1Mbps at 2.4GHz and 6Mbps at 5GHz.

---
Chun-Yeow

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

author
#5 lore raw
Quoted 47 lines · Yeoh Chun-Yeow
Quoted 34 lines · Ben Greear
Quoted 15 lines · Yeoh Chun-Yeow
Quoted 10 lines · Ben Greear

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another
for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Quoted 7 lines

Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps).

So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate.

User-space API doesn't give the ability to set different fixed rates for different packet types, as far as I know.

So, the current firmware just ignores the fixed rate for management and broadcast
frames.

Quoted 6 lines

My firmware change makes the fixed rate apply equally to all types of frames.

Should I make my change optional for mgt/bcast , or should it always set mgt/bcast rates to the
same fixed rates as data packets use?

In iw, we have the following:
dev <devname> set mcast_rate <rate in Mbps>
dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] [mcs-<2.4|5> <MCS index>*]

Quoted 4 lines

mcast-rate should be something set for broadcast/multicast frame including the management and data frame. This allows us to have in example beacon frame to be transmitted with higher rate from 1Mbps at 2.4GHz and 6Mbps at 5GHz.

Thanks...I'll try to figure out how to work this into my firmware. But, it will require driver changes specific to my firmware as far as I can tell, so it will never make it upstream...

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#6 lore raw
Quoted 48 lines · Ben Greear
Quoted 47 lines · Yeoh Chun-Yeow
Quoted 34 lines · Ben Greear
Quoted 15 lines · Yeoh Chun-Yeow
Quoted 10 lines · Ben Greear

Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another
for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps.

I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice?

Quoted 7 lines

Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps).

So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate.

User-space API doesn't give the ability to set different fixed rates for different packet types, as far as I know.

So, the current firmware just ignores the fixed rate for management and broadcast
frames.

Quoted 6 lines

My firmware change makes the fixed rate apply equally to all types of frames.

Should I make my change optional for mgt/bcast , or should it always set mgt/bcast rates to the
same fixed rates as data packets use?

In iw, we have the following:
dev <devname> set mcast_rate <rate in Mbps>
dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] [mcs-<2.4|5> <MCS index>*]

Quoted 8 lines
Quoted 4 lines

mcast-rate should be something set for broadcast/multicast frame including the management and data frame. This allows us to have in example beacon frame to be transmitted with higher rate from 1Mbps at 2.4GHz and 6Mbps at 5GHz.

Thanks...I'll try to figure out how to work this into my firmware. But, it will require driver changes specific to my firmware as far as I can tell, so it will never make it upstream...

From what I can tell, you can only set mcast rates on IBSS and mesh interfaces, so my firmware changes will probably remain the only way to do this until someone adds support to the mac80211 stack and driver. The good news
is that my firmware change no driver changes, so it should work with upstream kernels.

I have uploaded another beta firmware that also fixes the rate for mcast/broadcast traffic (which was not properly being set when trying to set the rate with iw previously).

To set HT rates, you need my 'iw' patch I posted earlier to linux-wireless...and which may be found here:

https://github.com/greearb/iw-ct

See release notes and binaries here:

http://www.candelatech.com/downloads/ath10k-fw-beta/

Thanks,
Ben

Quoted 5 lines

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k