Skip to contentSkip to conversation

spi: pl022: Remove incorrect TxFIFO full reporting

PATCH Applied Alexander Sverdlin 2 participants 2 messages Feb 27, 2015 – Mar 6, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 spi: pl022: Remove incorrect TxFIFO full reporting

spi: pl022: Remove incorrect TxFIFO full reporting

According to PL022 specification, TNF bit states for "Transmit FIFO Not full". So the logic here is inverted. But "Receive Overrun Interrupt", which is handled here, is only triggered on Rx errors. So instead of fixing the if statement, remove the whole message.

---
 drivers/spi/spi-pl022.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/spi/spi-pl022.c +0 -3
index 8f67a46..f68cbf6 100644
@@ -1254,9 +1254,6 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id)
 		if (readw(SSP_SR(pl022->virtbase)) & SSP_SR_MASK_RFF)
 			dev_err(&pl022->adev->dev,
 				"RXFIFO is full\n");
-		if (readw(SSP_SR(pl022->virtbase)) & SSP_SR_MASK_TNF)
-			dev_err(&pl022->adev->dev,
-				"TXFIFO is full\n");
 
 		/*
 		 * Disable and clear interrupts, disable SSP,

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw
In reply to a message not in the archive
Quoted 6 lines · Alexander Sverdlin

spi: pl022: Remove incorrect TxFIFO full reporting

According to PL022 specification, TNF bit states for "Transmit FIFO Not full". So the logic here is inverted. But "Receive Overrun Interrupt", which is handled here, is only triggered on Rx errors. So instead of fixing the if statement, remove the whole message.

Applied, thanks.