commit 440fd52 drm/mm: Support 4GiB and larger ranges oops on 32bit kernel
Subsystems (2)
[cc'ing lists]
Quoted 60 lines · Krzysztof Kolasa
System ( 32bit, Intel 945GM ) hangs after some short time, oops:
------------[ cut here ]------------ kernel BUG at drivers/gpu/drm/drm_mm.c:305! invalid opcode: 0000 [#1] SMP Modules linked in: arc4 md4 cfg80211 8192cu(O) pci_stub vboxpci(O)vboxnetadp(O) vboxnetflt(O) vboxdrv(O)
snd_hda_codec_si3054snd_hda_codec_realteksnd_hda_codec_genericsnd_hda_intelsnd_hda_controllersnd_hda_codecsnd_hwdepsnd_pcmmicrocodesnd_seq_midisnd_seq_midi_eventsnd_rawmidijoydevserio_rawsnd_seqsnd_timersnd_seq_devicerfcomm bnep bluetooth i915 sndlpc_ichdrm_kms_helpersoundcore drmi2c_algo_bitparport_pcppdev videomac_hidcoretemp lp parportnls_utf8cifsusb_storagepsmouse 8139too 8139cp miiCPU: 0 PID: 1165 Comm: Xorg Tainted: G O 4.0.0-rc3-winsoft-x86+ #11 Hardware name: FUJITSU SIEMENS AMILO Pro Edition V3405 /AMILOPro Edition V3405 , BIOS R01-B0E 03/20/2007
task:f64e0db0ti:f4566000task.ti:f4566000
EIP: 0060:[<f88c7d62>] EFLAGS: 00213206 CPU: 0
EIP is atdrm_mm_insert_node_in_range_generic+0x432/0x4d0[drm]
EAX: 01000000 EBX:00c78000ECX:f6d4c908EDX: 00000000
ESI:f6d4c900EDI:f6d4c900EBP:f4567c78ESP:f4567bf8
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
CR0:8005003bCR2:b4a02000CR3:345f2000CR4:000007f0Stack: f4567c64 00000000 00800000 00000000 00800000 f6d4c900 ffffffff f4882700 00000000 00000000 00000000 00a88000 00000000 10000000 00478000 00000000 00000000 00000000 00000000 00f00000 00000000 00000000 00000000 f472c33c Call Trace: [<f8b2634e>] i915_gem_object_pin_view+0x3ce/0x840 [i915] [<f8b1f601>] ? i915_gem_obj_lookup_or_create_vma_view+0x41/0x160 [i915] [<f8b196d2>] i915_gem_execbuffer_reserve_vma.isra.11+0x62/0x100 [i915] [<f8b19a01>] i915_gem_execbuffer_reserve+0x291/0x2e0 [i915] [<f8b1a340>] i915_gem_do_execbuffer.isra.16+0x4f0/0xd10 [i915] [<c1189430>] ? poll_select_copy_remaining+0x100/0x100 [<c116a8fd>] ? __kmalloc+0x4d/0x190 [<f8b1bbdb>] i915_gem_execbuffer2+0x8b/0x2c0 [i915] [<f8b1bb50>] ? i915_gem_execbuffer+0x4e0/0x4e0 [i915] [<f88bffa7>] drm_ioctl+0x1b7/0x510 [drm] [<f8b1bb50>] ? i915_gem_execbuffer+0x4e0/0x4e0 [i915] [<c10aac52>] ? ktime_get_ts64+0x52/0x1a0 [<f88bfdf0>] ? drm_getmap+0xb0/0xb0 [drm] [<c11888ea>] do_vfs_ioctl+0x30a/0x530 [<c1305626>] ? _copy_to_user+0x26/0x30 [<c10aac52>] ? ktime_get_ts64+0x52/0x1a0 [<c1190ee2>] ? __fget_light+0x22/0x60 [<c1188b70>] SyS_ioctl+0x60/0x90 [<c1630ec8>] sysenter_do_call+0x12/0x12 Code: ff ff 3b 55 e8 8d 74 26 00 77 10 73 04 0f 0b 66 90 3b 45 e4 908d 74 26 00 72 f2 8b 75 94 03 46 20 13 56 24 3b 55 f0 72 0d 76 06 <0f> 0b 8d 74 26 00 3b 45 ec 77 f5 39 55 c4 77 10 73 04 0f 0b 66
EIP: [<f88c7d62>]drm_mm_insert_node_in_range_generic+0x432/0x4d0[drm] SS:ESP 0068:f4567bf8---[ end trace 4648f53699b9eb32 ]---after revert commit 440fd52 system working OK
Krzysztof
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Problem solved and tested:
[PATCH] drm/mm: Fix support 4 GiB and larger ranges
bad argument if(tmp)... in check_free_hole
fix oops: kernel BUG at drivers/gpu/drm/drm_mm.c:305!
--- drivers/gpu/drm/drm_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_mm.c +1 -1
@@ -403,7 +403,7 @@ static int check_free_hole(u64 start, u64 end, u64 size, unsigned alignment)unsigned rem; rem =do_div (tmp, alignment); -if (tmp) +if (rem) start += alignment - rem; }
Signature · 1 line
2.3.3.dirty
Quoted 63 lines · Chris Wilson
[cc'ing lists]
Quoted 60 lines · Krzysztof Kolasa
System ( 32bit, Intel 945GM ) hangs after some short time, oops:
------------[ cut here ]------------ kernel BUG at drivers/gpu/drm/drm_mm.c:305! invalid opcode: 0000 [#1] SMP Modules linked in: arc4 md4 cfg80211 8192cu(O) pci_stub vboxpci(O)vboxnetadp(O) vboxnetflt(O) vboxdrv(O)
snd_hda_codec_si3054snd_hda_codec_realteksnd_hda_codec_genericsnd_hda_intelsnd_hda_controllersnd_hda_codecsnd_hwdepsnd_pcmmicrocodesnd_seq_midisnd_seq_midi_eventsnd_rawmidijoydevserio_rawsnd_seqsnd_timersnd_seq_devicerfcomm bnep bluetooth i915 sndlpc_ichdrm_kms_helpersoundcore drmi2c_algo_bitparport_pcppdev videomac_hidcoretemp lp parportnls_utf8cifsusb_storagepsmouse 8139too 8139cp miiCPU: 0 PID: 1165 Comm: Xorg Tainted: G O 4.0.0-rc3-winsoft-x86+ #11 Hardware name: FUJITSU SIEMENS AMILO Pro Edition V3405 /AMILOPro Edition V3405 , BIOS R01-B0E 03/20/2007
task:f64e0db0ti:f4566000task.ti:f4566000
EIP: 0060:[<f88c7d62>] EFLAGS: 00213206 CPU: 0
EIP is atdrm_mm_insert_node_in_range_generic+0x432/0x4d0[drm]
EAX: 01000000 EBX:00c78000ECX:f6d4c908EDX: 00000000
ESI:f6d4c900EDI:f6d4c900EBP:f4567c78ESP:f4567bf8
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
CR0:8005003bCR2:b4a02000CR3:345f2000CR4:000007f0Stack: f4567c64 00000000 00800000 00000000 00800000 f6d4c900 ffffffff f4882700 00000000 00000000 00000000 00a88000 00000000 10000000 00478000 00000000 00000000 00000000 00000000 00f00000 00000000 00000000 00000000 f472c33c Call Trace: [<f8b2634e>] i915_gem_object_pin_view+0x3ce/0x840 [i915] [<f8b1f601>] ? i915_gem_obj_lookup_or_create_vma_view+0x41/0x160 [i915] [<f8b196d2>] i915_gem_execbuffer_reserve_vma.isra.11+0x62/0x100 [i915] [<f8b19a01>] i915_gem_execbuffer_reserve+0x291/0x2e0 [i915] [<f8b1a340>] i915_gem_do_execbuffer.isra.16+0x4f0/0xd10 [i915] [<c1189430>] ? poll_select_copy_remaining+0x100/0x100 [<c116a8fd>] ? __kmalloc+0x4d/0x190 [<f8b1bbdb>] i915_gem_execbuffer2+0x8b/0x2c0 [i915] [<f8b1bb50>] ? i915_gem_execbuffer+0x4e0/0x4e0 [i915] [<f88bffa7>] drm_ioctl+0x1b7/0x510 [drm] [<f8b1bb50>] ? i915_gem_execbuffer+0x4e0/0x4e0 [i915] [<c10aac52>] ? ktime_get_ts64+0x52/0x1a0 [<f88bfdf0>] ? drm_getmap+0xb0/0xb0 [drm] [<c11888ea>] do_vfs_ioctl+0x30a/0x530 [<c1305626>] ? _copy_to_user+0x26/0x30 [<c10aac52>] ? ktime_get_ts64+0x52/0x1a0 [<c1190ee2>] ? __fget_light+0x22/0x60 [<c1188b70>] SyS_ioctl+0x60/0x90 [<c1630ec8>] sysenter_do_call+0x12/0x12 Code: ff ff 3b 55 e8 8d 74 26 00 77 10 73 04 0f 0b 66 90 3b 45 e4 908d 74 26 00 72 f2 8b 75 94 03 46 20 13 56 24 3b 55 f0 72 0d 76 06 <0f> 0b 8d 74 26 00 3b 45 ec 77 f5 39 55 c4 77 10 73 04 0f 0b 66
EIP: [<f88c7d62>]drm_mm_insert_node_in_range_generic+0x432/0x4d0[drm] SS:ESP 0068:f4567bf8---[ end trace 4648f53699b9eb32 ]---after revert commit 440fd52 system working OK
Krzysztof
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson
Reviewed-byQuoted 9 lines · Krzysztof Kolasa
Problem solved and tested:
[PATCH] drm/mm: Fix support 4 GiB and larger ranges
bad argument if(tmp)... in
check_free_holefix oops: kernel BUG at
drivers/gpu/drm/drm_mm.c:305!Signed-off-by Krzysztof Kolasa <[email protected]>
Nice catch!
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Dave Airlie
maintainerQuoted 7 lines · Chris Wilson
Quoted 6 lines · Krzysztof Kolasa
Problem solved and tested:
[PATCH] drm/mm: Fix support 4 GiB and larger ranges
bad argument if(tmp)... in
check_free_hole
Quoted 7 lines
Quoted 3 lines
fix oops: kernel BUG at
drivers/gpu/drm/drm_mm.c:305!Signed-off-by Krzysztof Kolasa <[email protected]>Nice catch!
Reviewed-by Chris wilson <[email protected]>-Chris
Nice work, that was what I planned on doing today, I've sent to Linus and already merged for rc4.
Dave.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Dave Airlie
Quoted 9 lines · Chris Wilson
Quoted 8 lines · Krzysztof Kolasa
Problem solved and tested:
[PATCH] drm/mm: Fix support 4 GiB and larger ranges
bad argument if(tmp)... in
check_free_holefix oops: kernel BUG at
drivers/gpu/drm/drm_mm.c:305!
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Krzysztof Kolasa <[email protected]>Nice catch!
Reviewed-by Chris wilson <[email protected]>-Chris
Nice work, that was what I planned on doing today, I've sent to Linus and already merged for rc4.
I was somewhat surprised that this patch got merged. I think Russell had some objections to it (he would've preferred to see it use page-granular allocations and hence avoid the need to switch to u64).
But since it's already landed in Linus' tree and this fix in v4.0-rc4 I guess it'd be too much churn to back it out again.
Thierry
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx